Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-06 Thread Markus Armbruster
Alexander Graf writes: > On 06.02.2014, at 15:41, Markus Armbruster wrote: > >> Paolo Bonzini writes: >> >>> Il 04/02/2014 13:14, Markus Armbruster ha scritto: Paolo Bonzini writes: > Il 04/02/2014 11:33, Markus Armbruster ha scritto: >> >>This breaks migration unl

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-06 Thread Alexander Graf
On 06.02.2014, at 15:41, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Il 04/02/2014 13:14, Markus Armbruster ha scritto: >>> Paolo Bonzini writes: >>> Il 04/02/2014 11:33, Markus Armbruster ha scritto: > >This breaks migration unless you change bus=ide.0 to bus=ide

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-06 Thread Markus Armbruster
Paolo Bonzini writes: > Il 04/02/2014 13:14, Markus Armbruster ha scritto: >> Paolo Bonzini writes: >> >>> Il 04/02/2014 11:33, Markus Armbruster ha scritto: This breaks migration unless you change bus=ide.0 to bus=ide.1 on the destination. Should be mentioned in

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-05 Thread Paolo Bonzini
Il 04/02/2014 13:14, Markus Armbruster ha scritto: Paolo Bonzini writes: Il 04/02/2014 11:33, Markus Armbruster ha scritto: This breaks migration unless you change bus=ide.0 to bus=ide.1 on the destination. Should be mentioned in release notes. Do we have a place where we collect r

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-04 Thread Markus Armbruster
Paolo Bonzini writes: > Il 04/02/2014 11:33, Markus Armbruster ha scritto: >> >> This breaks migration unless you change bus=ide.0 to bus=ide.1 on >> the destination. >> >> Should be mentioned in release notes. Do we have a place where we >> collect release notes as we go? > > Yes, http:

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-04 Thread Paolo Bonzini
Il 04/02/2014 11:33, Markus Armbruster ha scritto: This breaks migration unless you change bus=ide.0 to bus=ide.1 on the destination. Should be mentioned in release notes. Do we have a place where we collect release notes as we go? Yes, http://wiki.qemu.org/ChangeLog/Next Paolo

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-04 Thread Markus Armbruster
Actually [PATCH v3]. Alexander Graf writes: > When we have 2 separate qdev devices that both create a qbus of the > same type without specifying a bus name or device name, we end up > with two buses of the same name, such as ide.0 on the Mac machines: > > dev: macio-ide, id "" > bus: ide.0

[Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2014-02-03 Thread Alexander Graf
When we have 2 separate qdev devices that both create a qbus of the same type without specifying a bus name or device name, we end up with two buses of the same name, such as ide.0 on the Mac machines: dev: macio-ide, id "" bus: ide.0 type IDE dev: macio-ide, id "" bus: ide.0

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-05 Thread Paolo Bonzini
Il 05/12/2013 12:20, Markus Armbruster ha scritto: > Paolo Bonzini writes: > >> Il 05/12/2013 10:44, Markus Armbruster ha scritto: >>> Incompatible change: device ide-cd moved to a different controller. >> >> Yes, it should be stated in the commit message but it's expected as >> discussed yesterd

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-05 Thread Markus Armbruster
Paolo Bonzini writes: > Il 05/12/2013 10:44, Markus Armbruster ha scritto: >> Incompatible change: device ide-cd moved to a different controller. > > Yes, it should be stated in the commit message but it's expected as > discussed yesterday on IRC. The solution is not to use "-device" (which > wa

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-05 Thread Paolo Bonzini
Il 05/12/2013 10:44, Markus Armbruster ha scritto: > Incompatible change: device ide-cd moved to a different controller. Yes, it should be stated in the commit message but it's expected as discussed yesterday on IRC. The solution is not to use "-device" (which was broken) if you care about backwa

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-05 Thread Markus Armbruster
Alexander Graf writes: > When we have 2 separate qdev devices that both create a qbus of the > same type without specifying a bus name or device name, we end up > with two buses of the same name, such as ide.0 on the Mac machines: > > dev: macio-ide, id "" > bus: ide.0 > type IDE >

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-05 Thread Markus Armbruster
Alexander Graf writes: > When we have 2 separate qdev devices that both create a qbus of the > same type without specifying a bus name or device name, we end up > with two buses of the same name, such as ide.0 on the Mac machines: > > dev: macio-ide, id "" > bus: ide.0 > type IDE >

Re: [Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-05 Thread Paolo Bonzini
Il 04/12/2013 21:24, Alexander Graf ha scritto: > When we have 2 separate qdev devices that both create a qbus of the > same type without specifying a bus name or device name, we end up > with two buses of the same name, such as ide.0 on the Mac machines: > > dev: macio-ide, id "" > bus: ide

[Qemu-devel] [PATCH] qdev: Keep global allocation counter per bus

2013-12-04 Thread Alexander Graf
When we have 2 separate qdev devices that both create a qbus of the same type without specifying a bus name or device name, we end up with two buses of the same name, such as ide.0 on the Mac machines: dev: macio-ide, id "" bus: ide.0 type IDE dev: macio-ide, id "" bus: ide.0