Re: [Qemu-devel] [PATCH] qcow2: Fix qcow2_make_empty() with external data file

2019-04-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190429105741.31033-1-kw...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time ma

Re: [Qemu-devel] [PATCH] qcow2: Fix qcow2_make_empty() with external data file

2019-04-30 Thread Eric Blake
On 4/30/19 8:54 AM, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190429105741.31033-1-kw...@redhat.com/ > > > > Hi, > > This series failed the docker-mingw@fedora build test. Please find the > testing commands and > their output below. If you have Docker installed, you

Re: [Qemu-devel] [PATCH] qcow2: Fix qcow2_make_empty() with external data file

2019-04-30 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190429105741.31033-1-kw...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/

Re: [Qemu-devel] [PATCH] qcow2: Fix qcow2_make_empty() with external data file

2019-04-29 Thread Eric Blake
On 4/29/19 6:21 AM, Kevin Wolf wrote: > Am 29.04.2019 um 12:57 hat Kevin Wolf geschrieben: >> make_completely_empty() is an optimisated path for bdrv_make_empty() >> where completely new metadata is created inside the image file instead >> of going through all clusters and discarding them. For an e

Re: [Qemu-devel] [PATCH] qcow2: Fix qcow2_make_empty() with external data file

2019-04-29 Thread Kevin Wolf
Am 29.04.2019 um 12:57 hat Kevin Wolf geschrieben: > make_completely_empty() is an optimisated path for bdrv_make_empty() > where completely new metadata is created inside the image file instead > of going through all clusters and discarding them. For an external data > file, however, we actually n

[Qemu-devel] [PATCH] qcow2: Fix qcow2_make_empty() with external data file

2019-04-29 Thread Kevin Wolf
make_completely_empty() is an optimisated path for bdrv_make_empty() where completely new metadata is created inside the image file instead of going through all clusters and discarding them. For an external data file, however, we actually need to do discard operations on the data file; just overwri