Re: [Qemu-devel] [PATCH] qapi: Fix cgen() for Python older than 2.7

2015-09-14 Thread Peter Maydell
On 8 September 2015 at 07:38, Markus Armbruster wrote: > Peter, are you willing to commit this directly as a build fix? Or would > you prefer a pull request? Applied to master, thanks (sorry I missed this email earlier). -- PMM

Re: [Qemu-devel] [PATCH] qapi: Fix cgen() for Python older than 2.7

2015-09-08 Thread Markus Armbruster
Peter Maydell writes: > On 7 September 2015 at 16:45, Markus Armbruster wrote: >> A feature new in Python 2.7 crept into commit 77e703b: re.subn()'s >> fifth argument. Avoid that, use re.compile(). >> >> Reported-by: Laurent Desnogues >> Signed-off-by: Markus Armbruster > > Should we cc: stab

Re: [Qemu-devel] [PATCH] qapi: Fix cgen() for Python older than 2.7

2015-09-08 Thread Peter Maydell
On 7 September 2015 at 16:45, Markus Armbruster wrote: > A feature new in Python 2.7 crept into commit 77e703b: re.subn()'s > fifth argument. Avoid that, use re.compile(). > > Reported-by: Laurent Desnogues > Signed-off-by: Markus Armbruster Should we cc: stable on this? thanks -- PMM

Re: [Qemu-devel] [PATCH] qapi: Fix cgen() for Python older than 2.7

2015-09-07 Thread Markus Armbruster
Peter, are you willing to commit this directly as a build fix? Or would you prefer a pull request?

Re: [Qemu-devel] [PATCH] qapi: Fix cgen() for Python older than 2.7

2015-09-07 Thread Laurent Desnogues
On Mon, Sep 7, 2015 at 5:45 PM, Markus Armbruster wrote: > A feature new in Python 2.7 crept into commit 77e703b: re.subn()'s > fifth argument. Avoid that, use re.compile(). > > Reported-by: Laurent Desnogues > Signed-off-by: Markus Armbruster Tested-by: Laurent Desnogues Works fine here. Th

Re: [Qemu-devel] [PATCH] qapi: Fix cgen() for Python older than 2.7

2015-09-07 Thread Eric Blake
On 09/07/2015 09:45 AM, Markus Armbruster wrote: > A feature new in Python 2.7 crept into commit 77e703b: re.subn()'s > fifth argument. Avoid that, use re.compile(). > > Reported-by: Laurent Desnogues > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 4 +++- > 1 file changed, 3 inse

[Qemu-devel] [PATCH] qapi: Fix cgen() for Python older than 2.7

2015-09-07 Thread Markus Armbruster
A feature new in Python 2.7 crept into commit 77e703b: re.subn()'s fifth argument. Avoid that, use re.compile(). Reported-by: Laurent Desnogues Signed-off-by: Markus Armbruster --- scripts/qapi.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/qapi.py b/scripts/