Re: [Qemu-devel] [PATCH] qapi: Accept 'null' in QMP

2015-04-29 Thread Eric Blake
On 04/02/2015 01:31 PM, Eric Blake wrote: > We document that in QMP, the client may send any json-value > for the optional "id" key, and then return that same value > on reply (both success and failures, insofar as the failure > happened after parsing the id). [Note that the output may > not be id

Re: [Qemu-devel] [PATCH] qapi: Accept 'null' in QMP

2015-04-07 Thread Eric Blake
On 04/07/2015 06:46 AM, Alberto Garcia wrote: > On Thu, Apr 02, 2015 at 01:31:46PM -0600, Eric Blake wrote: > >> So instead, this patch creates a new QObject subtype: QNull. > > The code looks good, but Markus's approach of using a single instance > seems probably a bit better for this case. It'

Re: [Qemu-devel] [PATCH] qapi: Accept 'null' in QMP

2015-04-07 Thread Alberto Garcia
On Thu, Apr 02, 2015 at 01:31:46PM -0600, Eric Blake wrote: > So instead, this patch creates a new QObject subtype: QNull. The code looks good, but Markus's approach of using a single instance seems probably a bit better for this case. > --- /dev/null > +++ b/include/qapi/qmp/qnull.h > @@ -0,0 +

[Qemu-devel] [PATCH] qapi: Accept 'null' in QMP

2015-04-02 Thread Eric Blake
We document that in QMP, the client may send any json-value for the optional "id" key, and then return that same value on reply (both success and failures, insofar as the failure happened after parsing the id). [Note that the output may not be identical to the input, as whitespace may change and s