Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-09-14 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Sep 14, 2015 at 09:09:12AM -0600, Eric Blake wrote: >> On 09/13/2015 03:28 AM, Michael S. Tsirkin wrote: >> > On Fri, Sep 11, 2015 at 03:44:47PM -0300, Eduardo Habkost wrote: >> >> Ping? >> >> >> >> So, what's the reason we are still keeping those old machines in

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-09-14 Thread Eduardo Habkost
On Mon, Sep 14, 2015 at 09:09:12AM -0600, Eric Blake wrote: > On 09/13/2015 03:28 AM, Michael S. Tsirkin wrote: > > On Fri, Sep 11, 2015 at 03:44:47PM -0300, Eduardo Habkost wrote: > >> Ping? > >> > >> So, what's the reason we are still keeping those old machines in the > >> code? > > > > Victor a

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-09-14 Thread Eric Blake
On 09/13/2015 03:28 AM, Michael S. Tsirkin wrote: > On Fri, Sep 11, 2015 at 03:44:47PM -0300, Eduardo Habkost wrote: >> Ping? >> >> So, what's the reason we are still keeping those old machines in the >> code? > > Victor also wanted to clean out some very old machine types for > the PIIX, too. >

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-09-14 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Fri, Sep 11, 2015 at 03:44:47PM -0300, Eduardo Habkost wrote: >> Ping? >> >> So, what's the reason we are still keeping those old machines in the >> code? > > Victor also wanted to clean out some very old machine types for > the PIIX, too. > > But if someone cre

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-09-13 Thread Michael S. Tsirkin
On Fri, Sep 11, 2015 at 03:44:47PM -0300, Eduardo Habkost wrote: > Ping? > > So, what's the reason we are still keeping those old machines in the > code? Victor also wanted to clean out some very old machine types for the PIIX, too. But if someone created a machine with libvirt, these machine ty

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-09-11 Thread Markus Armbruster
Eduardo Habkost writes: > Ping? > > So, what's the reason we are still keeping those old machines in the > code? Inertia?

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-09-11 Thread Eduardo Habkost
Ping? So, what's the reason we are still keeping those old machines in the code? On Tue, Aug 18, 2015 at 04:11:42PM -0700, Eduardo Habkost wrote: > Migration with q35 was not possible before commit > 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates > an ich9-ahci dev

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-28 Thread Eduardo Habkost
On Fri, Aug 28, 2015 at 12:00:58PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote: > >> On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote: > >> > On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus A

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-28 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote: >> On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote: >> > On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote: >> > > John Snow writes: >> > > >> > > > On 08/19/2015 02:

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-27 Thread Eduardo Habkost
On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote: > > On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote: > > > John Snow writes: > > > > > > > On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wro

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-27 Thread Daniel P. Berrange
On Thu, Aug 27, 2015 at 02:05:49PM +0300, Michael S. Tsirkin wrote: > On Thu, Aug 27, 2015 at 12:01:17PM +0100, Daniel P. Berrange wrote: > > On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote: > > > > On Mon,

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 12:01:17PM +0100, Daniel P. Berrange wrote: > On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote: > > > On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote: > > > > John Sno

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-27 Thread Daniel P. Berrange
On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote: > > On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote: > > > John Snow writes: > > > > > > > On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wro

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-27 Thread Michael S. Tsirkin
On Tue, Aug 25, 2015 at 12:16:04PM -0400, John Snow wrote: > > > On 08/25/2015 05:42 AM, Michael S. Tsirkin wrote: > > On Wed, Aug 19, 2015 at 09:30:20AM -0700, Eduardo Habkost wrote: > >> On Wed, Aug 19, 2015 at 10:55:26AM +0100, Dr. David Alan Gilbert wrote: > >>> * Eduardo Habkost (ehabk...@re

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-27 Thread Michael S. Tsirkin
On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote: > On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote: > > John Snow writes: > > > > > On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wrote: > > >> * Eduardo Habkost (ehabk...@redhat.com) wrote: > > >>> Migration wi

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-25 Thread Daniel P. Berrange
On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote: > John Snow writes: > > > On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wrote: > >> * Eduardo Habkost (ehabk...@redhat.com) wrote: > >>> Migration with q35 was not possible before commit > >>> 04329029a8c539eb5f75dcb6d8b016f0c53a

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-25 Thread John Snow
On 08/25/2015 05:42 AM, Michael S. Tsirkin wrote: > On Wed, Aug 19, 2015 at 09:30:20AM -0700, Eduardo Habkost wrote: >> On Wed, Aug 19, 2015 at 10:55:26AM +0100, Dr. David Alan Gilbert wrote: >>> * Eduardo Habkost (ehabk...@redhat.com) wrote: Migration with q35 was not possible before commit

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-25 Thread Michael S. Tsirkin
On Wed, Aug 19, 2015 at 09:30:20AM -0700, Eduardo Habkost wrote: > On Wed, Aug 19, 2015 at 10:55:26AM +0100, Dr. David Alan Gilbert wrote: > > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > > Migration with q35 was not possible before commit > > > 04329029a8c539eb5f75dcb6d8b016f0c53a031a, becau

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-25 Thread Marcel Apfelbaum
On 08/24/2015 12:54 PM, Markus Armbruster wrote: John Snow writes: On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wrote: * Eduardo Habkost (ehabk...@redhat.com) wrote: Migration with q35 was not possible before commit 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally crea

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-24 Thread John Snow
On 08/24/2015 02:54 AM, Markus Armbruster wrote: > John Snow writes: > >> On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wrote: >>> * Eduardo Habkost (ehabk...@redhat.com) wrote: Migration with q35 was not possible before commit 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 un

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-24 Thread Markus Armbruster
John Snow writes: > On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wrote: >> * Eduardo Habkost (ehabk...@redhat.com) wrote: >>> Migration with q35 was not possible before commit >>> 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally >>> creates >>> an ich9-ahci device, that wa

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-21 Thread Laszlo Ersek
On 08/19/15 01:11, Eduardo Habkost wrote: > Migration with q35 was not possible before commit > 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates > an ich9-ahci device, that was marked as unmigratable. So all q35 machines > before pc-q35-2.4 were unmigratable, and there'

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-20 Thread John Snow
On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: >> Migration with q35 was not possible before commit >> 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates >> an ich9-ahci device, that was marked as unmigratable. So

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-19 Thread Eduardo Habkost
On Wed, Aug 19, 2015 at 10:55:26AM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > Migration with q35 was not possible before commit > > 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally > > creates > > an ich9-ahci device, that was mar

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-19 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > Migration with q35 was not possible before commit > 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates > an ich9-ahci device, that was marked as unmigratable. So all q35 machines > before pc-q35-2.4 were unmigratable, and t

[Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-18 Thread Eduardo Habkost
Migration with q35 was not possible before commit 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates an ich9-ahci device, that was marked as unmigratable. So all q35 machines before pc-q35-2.4 were unmigratable, and there's no point in keeping compatibility code for them.