Re: [Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Anthony Liguori
Peter Maydell writes: > On 3 January 2013 19:00, Anthony Liguori wrote: >> Thanks, applied. > > So we now say "char device redirected to /dev/pts/5 (compat_monitor0)" > rather than "char device compat_monitor0 redirected to /dev/pts/5" ? > I think that's a reduction in clarity and it's sad that

Re: [Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Peter Maydell
On 3 January 2013 19:00, Anthony Liguori wrote: > Thanks, applied. So we now say "char device redirected to /dev/pts/5 (compat_monitor0)" rather than "char device compat_monitor0 redirected to /dev/pts/5" ? I think that's a reduction in clarity and it's sad that we have to do it. I also think th

Re: [Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Anthony Liguori
Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Anthony Liguori
"Daniel P. Berrange" writes: > On Thu, Jan 03, 2013 at 02:23:03PM +0100, Gerd Hoffmann wrote: >> Commit 586502189edf9fd0f89a83de96717a2ea826fdb0 breaks libvirt pty >> support because it tried to figure the pts name from stderr output. >> >> Fix this by moving the label to the end of the line, th

Re: [Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Daniel P. Berrange
On Thu, Jan 03, 2013 at 02:23:03PM +0100, Gerd Hoffmann wrote: > Commit 586502189edf9fd0f89a83de96717a2ea826fdb0 breaks libvirt pty > support because it tried to figure the pts name from stderr output. > > Fix this by moving the label to the end of the line, this way the > libvirt parser does stil

[Qemu-devel] [PATCH] pty: unbreak libvirt

2013-01-03 Thread Gerd Hoffmann
Commit 586502189edf9fd0f89a83de96717a2ea826fdb0 breaks libvirt pty support because it tried to figure the pts name from stderr output. Fix this by moving the label to the end of the line, this way the libvirt parser does still recognise the message. libvirt looks for "char device redirected to ${