Am 14.08.2013 13:03, schrieb Edgar E. Iglesias:
> On Wed, Aug 14, 2013 at 12:03:34PM +0200, Alexander Graf wrote:
>> Then let's make the logic work like this:
>>
>> if (user provided -dtb) {
>> if (load_dtb(user provided dtb)) {
>> abort();
>> }
>> } else {
>> if (load_dtb("ppc.dtb")) {
>
On 14.08.2013, at 13:03, Edgar E. Iglesias wrote:
> On Wed, Aug 14, 2013 at 12:03:34PM +0200, Alexander Graf wrote:
>>
>> On 14.08.2013, at 11:56, Edgar E. Iglesias wrote:
>>
>>> On Wed, Aug 14, 2013 at 11:51:19AM +0200, Alexander Graf wrote:
On 13.08.2013, at 13:09, Efimov Vasily wr
On Wed, Aug 14, 2013 at 12:03:34PM +0200, Alexander Graf wrote:
>
> On 14.08.2013, at 11:56, Edgar E. Iglesias wrote:
>
> > On Wed, Aug 14, 2013 at 11:51:19AM +0200, Alexander Graf wrote:
> >>
> >> On 13.08.2013, at 13:09, Efimov Vasily wrote:
> >>
> >>>
> >>> Signed-off-by: Efimov Vasily
> >
On 14.08.2013, at 12:34, Felix Deichmann wrote:
> 2013/8/14 Alexander Graf :
>>> -void *fdt;
>>> +void *fdt = 0;
>>
>> This should be NULL. NULL doesn't have to be 0 according to C IIRC.
>
> The last statement is wrong here, NULL is always the same as 0
> language-wise. Although the abo
2013/8/14 Alexander Graf :
>> -void *fdt;
>> +void *fdt = 0;
>
> This should be NULL. NULL doesn't have to be 0 according to C IIRC.
The last statement is wrong here, NULL is always the same as 0
language-wise. Although the above code is always correct, some will
consider it better style t
On 14.08.2013, at 11:56, Edgar E. Iglesias wrote:
> On Wed, Aug 14, 2013 at 11:51:19AM +0200, Alexander Graf wrote:
>>
>> On 13.08.2013, at 13:09, Efimov Vasily wrote:
>>
>>>
>>> Signed-off-by: Efimov Vasily
>>
>> Please provide a patch description :).
>>
>>> ---
>>> hw/ppc/virtex_ml507.c |
On Wed, Aug 14, 2013 at 11:51:19AM +0200, Alexander Graf wrote:
>
> On 13.08.2013, at 13:09, Efimov Vasily wrote:
>
> >
> > Signed-off-by: Efimov Vasily
>
> Please provide a patch description :).
>
> > ---
> > hw/ppc/virtex_ml507.c | 13 ++---
> > 1 file changed, 10 insertions(+), 3
On 13.08.2013, at 13:09, Efimov Vasily wrote:
>
> Signed-off-by: Efimov Vasily
Please provide a patch description :).
> ---
> hw/ppc/virtex_ml507.c | 13 ++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
> index 0
Signed-off-by: Efimov Vasily
---
hw/ppc/virtex_ml507.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
index 08e77fb..a00f709 100644
--- a/hw/ppc/virtex_ml507.c
+++ b/hw/ppc/virtex_ml507.c
@@ -141,11 +141,18 @@ st
