Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-03 Thread Thiemo Seufer
Fabrice Bellard wrote: > Thiemo Seufer wrote: > >Thiemo Seufer wrote: > >>Hello All, > >> > >>I changed the pcnet32 driver to get rid of bitfields in its > >>implementation, now it works also on big endian host systems. > >> > >>I tested only the 32 bit mode which is used by MIPS/Malta, and > >>I'm

Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-03 Thread Andreas Schwab
"M. Warner Losh" <[EMAIL PROTECTED]> writes: > True, but that's not what the original poster in this thread was > asking. Right. > Answering the different question is just confusing to the > original poster. It was actually me who was confused. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL P

Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-03 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Andreas Schwab <[EMAIL PROTECTED]> writes: : "M. Warner Losh" <[EMAIL PROTECTED]> writes: : : > Except that compilers use the convention that was described above. : > Big endian MIPS definitely uses a different bit ordering for C bit : > fields than litt

Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-03 Thread Andreas Schwab
"M. Warner Losh" <[EMAIL PROTECTED]> writes: > Except that compilers use the convention that was described above. > Big endian MIPS definitely uses a different bit ordering for C bit > fields than little endian MIPS. There is actually a difference between *bitfield* ordering and *bit* ordering.

Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-03 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Andreas Schwab <[EMAIL PROTECTED]> writes: : Paul Brook <[EMAIL PROTECTED]> writes: : : >> : I find this curious... C99 (6.7.2.1) says "the allocation order of : >> : bit-fields within a unit (high-order to low-order or low-order to : >> : high-order) i

Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-03 Thread Andreas Schwab
Paul Brook <[EMAIL PROTECTED]> writes: >> : I find this curious... C99 (6.7.2.1) says "the allocation order of >> : bit-fields within a unit (high-order to low-order or low-order to >> : high-order) is implementation defined". I can't see any requirement >> : for this, so is it just convention t

Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-02 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Paul Brook <[EMAIL PROTECTED]> writes: : > : I find this curious... C99 (6.7.2.1) says "the allocation order of : > : bit-fields within a unit (high-order to low-order or low-order to : > : high-order) is implementation defined". I can't see any require

Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-02 Thread Paul Brook
> : I find this curious... C99 (6.7.2.1) says "the allocation order of > : bit-fields within a unit (high-order to low-order or low-order to > : high-order) is implementation defined". I can't see any requirement > : for this, so is it just convention that bitfields on big endian systems > : star

Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-02 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Stuart Brady <[EMAIL PROTECTED]> writes: : On Fri, Mar 02, 2007 at 08:09:49PM +, Thiemo Seufer wrote: : > Hello All, : > : > I changed the pcnet32 driver to get rid of bitfields in its : > implementation, now it works also on big endian host systems.

Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-02 Thread Fabrice Bellard
Thiemo Seufer wrote: Thiemo Seufer wrote: Hello All, I changed the pcnet32 driver to get rid of bitfields in its implementation, now it works also on big endian host systems. I tested only the 32 bit mode which is used by MIPS/Malta, and I'm not sure if it still works in Lance mode (as e.g. us

Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-02 Thread Stuart Brady
On Fri, Mar 02, 2007 at 08:09:49PM +, Thiemo Seufer wrote: > Hello All, > > I changed the pcnet32 driver to get rid of bitfields in its > implementation, now it works also on big endian host systems. I find this curious... C99 (6.7.2.1) says "the allocation order of bit-fields within a unit

Re: [Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-02 Thread Thiemo Seufer
Thiemo Seufer wrote: > Hello All, > > I changed the pcnet32 driver to get rid of bitfields in its > implementation, now it works also on big endian host systems. > > I tested only the 32 bit mode which is used by MIPS/Malta, and > I'm not sure if it still works in Lance mode (as e.g. used on SPAR

[Qemu-devel] [PATCH] pcnet32 driver change, please test

2007-03-02 Thread Thiemo Seufer
Hello All, I changed the pcnet32 driver to get rid of bitfields in its implementation, now it works also on big endian host systems. I tested only the 32 bit mode which is used by MIPS/Malta, and I'm not sure if it still works in Lance mode (as e.g. used on SPARC). So please test if it still work