Re: [Qemu-devel] [PATCH] pcnet-pci: fix wrong opaque given to I/O accessors

2011-08-24 Thread Avi Kivity
On 08/22/2011 05:16 PM, Gerhard Wiesinger wrote: Hello Avi, Thnx, fixed: OK, maybe some credits :-) Acked-by: Gerhard Wiesinger This pattern is still present at (maybe some further problems!!!) and I guess it has to be fixed, too: grep -ir 'ops, s, "' . ./hw/rtl8139.c:memory_region_ini

Re: [Qemu-devel] [PATCH] pcnet-pci: fix wrong opaque given to I/O accessors

2011-08-22 Thread Gerhard Wiesinger
Hello Avi, Thnx, fixed: OK, maybe some credits :-) Acked-by: Gerhard Wiesinger This pattern is still present at (maybe some further problems!!!) and I guess it has to be fixed, too: grep -ir 'ops, s, "' . ./hw/rtl8139.c:memory_region_init_io(&s->bar_io, &rtl8139_io_ops, s, "rtl8139", 0

[Qemu-devel] [PATCH] pcnet-pci: fix wrong opaque given to I/O accessors

2011-08-22 Thread Avi Kivity
Another casualty of the memory API conversion. Signed-off-by: Avi Kivity --- hw/pcnet-pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pcnet-pci.c b/hw/pcnet-pci.c index 13d9380..51e1320 100644 --- a/hw/pcnet-pci.c +++ b/hw/pcnet-pci.c @@ -290,10 +290,10 @@ st