Re: [Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Casey Leedom
| From: Alex Williamson [alex.william...@redhat.com] | Sent: Thursday, June 25, 2015 1:57 PM | | We expose [the PBA Offset] to the guest VM, but the guest probably | doesn't consume it, I don't know of any drivers that do. Ah, okay. You're doing this for the Hypervisor traps of accesses to the

Re: [Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Casey Leedom
Hi Alex, the issue is that the T5 hardware has a bug in it where it reports a Pending Interrupt Bit Array Offset of 0x8000 for its SR-IOV Virtual Functions instead of the 0x1000 that the hardware actually uses internally. (There was a mistaken <<3 used in the IP Glue Logic for the PCI Configu

Re: [Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Casey Leedom
Oh, and by the way, I've already asked Gabriel to respin the patch because the quirk incorrectly trips for all T5 Functions instead of only for T5 Virtual Functions. So you should reject the first patch regardless. Thanks! Casey From: Casey Leedom Se

Re: [Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Alex Williamson
On Thu, 2015-06-25 at 20:22 +, Casey Leedom wrote: > Oh, and by the way, I've already asked Gabriel to respin the patch > because the quirk incorrectly trips for all T5 Functions instead of > only for T5 Virtual Functions. So you should reject the first patch > regardless. Thanks! > > Case

Re: [Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Alex Williamson
On Thu, 2015-06-25 at 19:00 +, Gabriel Laupre wrote: > @Bandan > > Is the array offset guaranteed to always be the same ? > The returned value depends on the physical function and should be 0x1000 for > the T5 series. Therefore this offset is guaranteed to always be the same. > > > What are t

Re: [Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Gabriel Laupre
@Bandan > Is the array offset guaranteed to always be the same ? The returned value depends on the physical function and should be 0x1000 for the T5 series. Therefore this offset is guaranteed to always be the same. > What are the chances of this getting fixed by a firmware update ? :) It isn't a

Re: [Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Alex Williamson
On Wed, 2015-06-24 at 19:04 -0700, Gabriel Laupre wrote: > Fix pba_offset initialization value for Chelsio T5 devices. The > hardware doesn't return the correct pba_offset value, so add a > quirk to instead return a hardcoded value of 0x1000 when a Chelsio > T5 device is detected. > > Signed-off-

[Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-25 Thread Gabriel Laupre
Fix pba_offset initialization value for Chelsio T5 devices. The hardware doesn't return the correct pba_offset value, so add a quirk to instead return a hardcoded value of 0x1000 when a Chelsio T5 device is detected. Signed-off-by: Gabriel Laupre --- hw/vfio/pci.c| 12

Re: [Qemu-devel] [PATCH] pci : Add pba_offset PCI quirk for Chelsio T5 devices

2015-06-24 Thread Bandan Das
Hi Gabriel, Glad that you got to the bottom of this! :) Gabriel Laupre writes: > Fix pba_offset initialization value for Chelsio T5 devices. The > hardware doesn't return the correct pba_offset value, so add a > quirk to instead return a hardcoded value of 0x1000 when a Chelsio > T5 device is