Re: [Qemu-devel] [PATCH] pci-devfn: check that device/slot number is within range

2011-09-23 Thread Anthony Liguori
On 09/21/2011 02:25 PM, Donald Dutile wrote: Need to check that guest slot/device number is not> 31 or walk off the devfn table when checking if a devfn is available or not in a guest. before this fix, passing in an addr=abc or addr=34, can crash qemu, sometimes fail gracefully if data past en

Re: [Qemu-devel] [PATCH] pci-devfn: check that device/slot number is within range

2011-09-22 Thread Markus Armbruster
Donald Dutile writes: > Need to check that guest slot/device number is not > 31 or walk off > the devfn table when checking if a devfn is available or not in a guest. Here in do_pci_register_device(): } else if (bus->devices[devfn]) { error_report("PCI: devfn %d not available for %s

[Qemu-devel] [PATCH] pci-devfn: check that device/slot number is within range

2011-09-21 Thread Donald Dutile
Need to check that guest slot/device number is not > 31 or walk off the devfn table when checking if a devfn is available or not in a guest. before this fix, passing in an addr=abc or addr=34, can crash qemu, sometimes fail gracefully if data past end of devfn table fails the availability test.