Re: [Qemu-devel] [PATCH] pci: unplug all devs of same slot once

2012-05-14 Thread Paolo Bonzini
Il 13/05/2012 12:54, Michael S. Tsirkin ha scritto: > This was done as part of 57c9fafe0f759c9f1efa5451662b3627f9bb95e0. > Should we just call object_unparent before qdev_free? > Anthony? Or just call object_unparent in object_delete? Paolo

Re: [Qemu-devel] [PATCH] pci: unplug all devs of same slot once

2012-05-13 Thread Michael S. Tsirkin
On Fri, May 11, 2012 at 10:57:25PM +0800, Amos Kong wrote: > The whole PCI slot should be removed once. Currently only one func > is cleaned in pci_unplug_device(), if you try to remove a single > func by monitor cmd. > > Start VM with 8 multiple-function block devs, hot-removing > those block dev

Re: [Qemu-devel] [PATCH] pci: unplug all devs of same slot once

2012-05-12 Thread Amos Kong
On Fri, May 11, 2012 at 10:57 PM, Amos Kong wrote: > The whole PCI slot should be removed once. Currently only one func > is cleaned in pci_unplug_device(), if you try to remove a single > func by monitor cmd. > > Start VM with 8 multiple-function block devs, hot-removing > those block devs by 'd

[Qemu-devel] [PATCH] pci: unplug all devs of same slot once

2012-05-11 Thread Amos Kong
The whole PCI slot should be removed once. Currently only one func is cleaned in pci_unplug_device(), if you try to remove a single func by monitor cmd. Start VM with 8 multiple-function block devs, hot-removing those block devs by 'device_del ...' would cause qemu abort. | (qemu) device_del virt