Re: [Qemu-devel] [PATCH] pc: remove useless hot_add_cpu initialisation

2017-10-11 Thread Anthony PERARD
On Tue, Oct 10, 2017 at 03:32:41PM +0200, Laurent Vivier wrote: > Since 4458fb3a79 (pc: Eliminate pc_default_machine_options()), > hot_add_cpu is set in pc_machine_class_init(), so we don't > need to set it in pc_q35_machine_options(), pc_i440fx_machine_options() > and xenfv_machine_options(), exce

Re: [Qemu-devel] [PATCH] pc: remove useless hot_add_cpu initialisation

2017-10-10 Thread Eduardo Habkost
On Tue, Oct 10, 2017 at 03:32:41PM +0200, Laurent Vivier wrote: > Since 4458fb3a79 (pc: Eliminate pc_default_machine_options()), > hot_add_cpu is set in pc_machine_class_init(), so we don't > need to set it in pc_q35_machine_options(), pc_i440fx_machine_options() > and xenfv_machine_options(), exce

Re: [Qemu-devel] [PATCH] pc: remove useless hot_add_cpu initialisation

2017-10-10 Thread Igor Mammedov
On Tue, 10 Oct 2017 15:32:41 +0200 Laurent Vivier wrote: > Since 4458fb3a79 (pc: Eliminate pc_default_machine_options()), > hot_add_cpu is set in pc_machine_class_init(), so we don't > need to set it in pc_q35_machine_options(), pc_i440fx_machine_options() > and xenfv_machine_options(), except to

[Qemu-devel] [PATCH] pc: remove useless hot_add_cpu initialisation

2017-10-10 Thread Laurent Vivier
Since 4458fb3a79 (pc: Eliminate pc_default_machine_options()), hot_add_cpu is set in pc_machine_class_init(), so we don't need to set it in pc_q35_machine_options(), pc_i440fx_machine_options() and xenfv_machine_options(), except to clear it in pc_i440fx_1_4_machine_opt(). Signed-off-by: Laurent V