Re: [Qemu-devel] [PATCH] pc: cleanup 1.4 compat support

2013-08-19 Thread Michael S. Tsirkin
On Mon, Aug 19, 2013 at 09:04:28AM -0300, Eduardo Habkost wrote: > On Sun, Aug 18, 2013 at 04:50:02PM +0300, Michael S. Tsirkin wrote: > > Make 1.4 compat code call the 1.6 one, reducing > > code duplication. Add comment explaining why we can't > > make 1.4 call 1.5 as usual. > > > > Signed-off-by

Re: [Qemu-devel] [PATCH] pc: cleanup 1.4 compat support

2013-08-19 Thread Eduardo Habkost
On Mon, Aug 19, 2013 at 05:28:45PM +0300, Michael S. Tsirkin wrote: > On Mon, Aug 19, 2013 at 11:19:23AM -0300, Eduardo Habkost wrote: > > On Mon, Aug 19, 2013 at 04:02:10PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Aug 19, 2013 at 09:04:28AM -0300, Eduardo Habkost wrote: > > > > On Sun, Aug 1

Re: [Qemu-devel] [PATCH] pc: cleanup 1.4 compat support

2013-08-19 Thread Michael S. Tsirkin
On Mon, Aug 19, 2013 at 11:19:23AM -0300, Eduardo Habkost wrote: > On Mon, Aug 19, 2013 at 04:02:10PM +0300, Michael S. Tsirkin wrote: > > On Mon, Aug 19, 2013 at 09:04:28AM -0300, Eduardo Habkost wrote: > > > On Sun, Aug 18, 2013 at 04:50:02PM +0300, Michael S. Tsirkin wrote: > > > > Make 1.4 comp

Re: [Qemu-devel] [PATCH] pc: cleanup 1.4 compat support

2013-08-19 Thread Eduardo Habkost
On Mon, Aug 19, 2013 at 04:02:10PM +0300, Michael S. Tsirkin wrote: > On Mon, Aug 19, 2013 at 09:04:28AM -0300, Eduardo Habkost wrote: > > On Sun, Aug 18, 2013 at 04:50:02PM +0300, Michael S. Tsirkin wrote: > > > Make 1.4 compat code call the 1.6 one, reducing > > > code duplication. Add comment ex

Re: [Qemu-devel] [PATCH] pc: cleanup 1.4 compat support

2013-08-19 Thread Eduardo Habkost
On Sun, Aug 18, 2013 at 04:50:02PM +0300, Michael S. Tsirkin wrote: > Make 1.4 compat code call the 1.6 one, reducing > code duplication. Add comment explaining why we can't > make 1.4 call 1.5 as usual. > > Signed-off-by: Michael S. Tsirkin > --- > hw/i386/pc_piix.c | 4 ++-- > hw/i386/pc_q35.c

Re: [Qemu-devel] [PATCH] pc: cleanup 1.4 compat support

2013-08-18 Thread Andreas Färber
Am 18.08.2013 15:50, schrieb Michael S. Tsirkin: > Make 1.4 compat code call the 1.6 one, reducing > code duplication. Add comment explaining why we can't > make 1.4 call 1.5 as usual. > > Signed-off-by: Michael S. Tsirkin > --- > hw/i386/pc_piix.c | 4 ++-- > hw/i386/pc_q35.c | 4 ++-- > 2 fil

[Qemu-devel] [PATCH] pc: cleanup 1.4 compat support

2013-08-18 Thread Michael S. Tsirkin
Make 1.4 compat code call the 1.6 one, reducing code duplication. Add comment explaining why we can't make 1.4 call 1.5 as usual. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 4 ++-- hw/i386/pc_q35.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/p