Re: [Qemu-devel] [PATCH] pc: apic: introduce APIC macro

2016-09-14 Thread Wanpeng Li
2016-09-15 14:27 GMT+08:00 Paolo Bonzini : [...] >> +#define TYPE_APIC "apic" >> +#define APIC(obj) \ >> +OBJECT_CHECK(APICCommonState, (obj), TYPE_APIC) > > This should be in apic.c. Also please replace the other occurrence of > "apic" in apic.c by TYPE_APIC. Will do, thanks for your review.

Re: [Qemu-devel] [PATCH] pc: apic: introduce APIC macro

2016-09-14 Thread Paolo Bonzini
On 15/09/2016 02:43, Wanpeng Li wrote: > From: Wanpeng Li > > Introduce a new APIC macro to replace APIC_COMMON macro in > hw/intc/apic.c in order to capture access LAPIC in qemu > even if LAPIC is emulated in kvm. > > Suggested-by: Paolo Bonzini > Cc: Paolo Bonzini > Cc: Radim Krčmář > C

Re: [Qemu-devel] [PATCH] pc: apic: introduce APIC macro

2016-09-14 Thread Michael S. Tsirkin
On Thu, Sep 15, 2016 at 08:43:33AM +0800, Wanpeng Li wrote: > From: Wanpeng Li > > Introduce a new APIC macro to replace APIC_COMMON macro in > hw/intc/apic.c in order to capture access LAPIC in qemu > even if LAPIC is emulated in kvm. > > Suggested-by: Paolo Bonzini > Cc: Paolo Bonzini > Cc

[Qemu-devel] [PATCH] pc: apic: introduce APIC macro

2016-09-14 Thread Wanpeng Li
From: Wanpeng Li Introduce a new APIC macro to replace APIC_COMMON macro in hw/intc/apic.c in order to capture access LAPIC in qemu even if LAPIC is emulated in kvm. Suggested-by: Paolo Bonzini Cc: Paolo Bonzini Cc: Radim Krčmář Cc: Michael S. Tsirkin Cc: Eduardo Habkost Signed-off-by: Wa