Hi,
> And that is actually simple enough that we can consider it for 1.7:
> >
> > static void *oss_audio_init (void)
> > {
> > +if (access(conf.devpath_in, R_OK | W_OK) < 0 ||
> > +access(conf.devpath_out, R_OK | W_OK) < 0) {
> > +return NULL;
>
> That would be reasonable
On Wed, Nov 6, 2013 at 7:20 AM, Gerd Hoffmann wrote:
> Hi,
>
>> > static void *oss_audio_init (void)
>> > {
>> > return &conf;
>> > }
>> >
>> > It never fails.
>>
>> OK, that's a bug. (I'd misread the calling function
>> audio_driver_init() as also checking that the init_in
>> and init_out f
Hi,
> > static void *oss_audio_init (void)
> > {
> > return &conf;
> > }
> >
> > It never fails.
>
> OK, that's a bug. (I'd misread the calling function
> audio_driver_init() as also checking that the init_in
> and init_out functions succeeded, which it does not.)
>
> > So audio is broken o
On 6 November 2013 14:54, Anthony Liguori wrote:
> I don't think you guys understand what is happening.
>
> As ossaudio is able to be default, it *will be selected* as the audio
> output backend unconditionally. You aren't seeing errors during
> probing, you're seeing errors post-initialization.
On Wed, Nov 6, 2013 at 3:15 AM, Gerd Hoffmann wrote:
> On Mi, 2013-11-06 at 10:48 +, Peter Maydell wrote:
>
>> > That is clearly 1.8 material though. I think for 1.7 we should simply
>> > leave things as-is.
>>
>> Do you mean "as-is with Anthony's patch applied", or "as it was
>> before that
On Mi, 2013-11-06 at 10:48 +, Peter Maydell wrote:
> > That is clearly 1.8 material though. I think for 1.7 we should simply
> > leave things as-is.
>
> Do you mean "as-is with Anthony's patch applied", or "as it was
> before that patch was applied" ?
Oh, it is in?
> I would suggest the l
On 6 November 2013 09:18, Gerd Hoffmann wrote:
> I think the audio backend handling needs a serious makeover. Detect
> sound libraries (pulse, esd, alsa, ...) via configure like any other
> library. Zap the whole can_be_default logic. Replace it by walking the
> list of backends, sorted by prio
On Di, 2013-11-05 at 20:34 +, Peter Maydell wrote:
> On 5 November 2013 19:57, Anthony Liguori wrote:
> > This patch just requires that you explicitly select oss so it's not
> > breaking audio on BSD.
>
> That sounds to me like it's breaking audio for all the
> users for whom it previously wo
On 5 November 2013 19:57, Anthony Liguori wrote:
> This patch just requires that you explicitly select oss so it's not
> breaking audio on BSD.
That sounds to me like it's breaking audio for all the
users for whom it previously worked out of the box
without any particular configure or command lin
On 5 November 2013 19:57, Anthony Liguori wrote:
> Since the oss code can fail to initialize without handling it
> gracefully, it really cannot be default on any platform.
Can you describe what the actual problem is we're trying
to fix here, please? I can't see a description of it
in any of the m
Gerd Hoffmann writes:
> On So, 2013-11-03 at 08:45 -0800, Anthony Liguori wrote:
>> Modern Linux's no longer support /dev/dsp so enabling it by
>> default causes audio failures on newer Linux distros.
>
> That will break sound on BSD.
>
> I think we should do something like this instead:
>
> ---
On 3 November 2013 16:45, Anthony Liguori wrote:
> Modern Linux's no longer support /dev/dsp so enabling it by
> default causes audio failures on newer Linux distros.
>
> Signed-off-by: Anthony Liguori
> ---
> audio/ossaudio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --gi
On So, 2013-11-03 at 08:45 -0800, Anthony Liguori wrote:
> Modern Linux's no longer support /dev/dsp so enabling it by
> default causes audio failures on newer Linux distros.
That will break sound on BSD.
I think we should do something like this instead:
--- a/configure
+++ b/configure
@@ -554,7
On Sun, Nov 3, 2013 at 9:12 AM, Andreas Färber wrote:
> Am 03.11.2013 17:45, schrieb Anthony Liguori:
>> Modern Linux's no longer support /dev/dsp so enabling it by
>> default causes audio failures on newer Linux distros.
>>
>> Signed-off-by: Anthony Liguori
>> ---
>> audio/ossaudio.c | 2 +-
>>
Am 03.11.2013 17:45, schrieb Anthony Liguori:
> Modern Linux's no longer support /dev/dsp so enabling it by
> default causes audio failures on newer Linux distros.
>
> Signed-off-by: Anthony Liguori
> ---
> audio/ossaudio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
With my current
Modern Linux's no longer support /dev/dsp so enabling it by
default causes audio failures on newer Linux distros.
Signed-off-by: Anthony Liguori
---
audio/ossaudio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/audio/ossaudio.c b/audio/ossaudio.c
index 007c641..3e04a58 100
16 matches
Mail list logo
