Re: [Qemu-devel] [PATCH] optionrom: fix compilation with mingw docker target

2016-08-09 Thread Paolo Bonzini
- Original Message - > From: "Peter Maydell" > To: "Paolo Bonzini" > Cc: "QEMU Developers" , "Richard W.M. Jones" > > Sent: Tuesday, August 9, 2016 11:47:17 PM > Subject: Re: [Qemu-devel] [PATCH] optionrom: fix compilation

Re: [Qemu-devel] [PATCH] optionrom: fix compilation with mingw docker target

2016-08-09 Thread Peter Maydell
On 9 August 2016 at 21:56, Paolo Bonzini wrote: > Two fixes are needed. First, mingw does not have -D_FORTIFY_SOURCE, > hence --enable-debug disables optimization. This is not acceptable > for ROMs, which should override CFLAGS to force inclusion of -O2. > > Second, PE stores global constructors

[Qemu-devel] [PATCH] optionrom: fix compilation with mingw docker target

2016-08-09 Thread Paolo Bonzini
Two fixes are needed. First, mingw does not have -D_FORTIFY_SOURCE, hence --enable-debug disables optimization. This is not acceptable for ROMs, which should override CFLAGS to force inclusion of -O2. Second, PE stores global constructors and destructors using the following linker script snippet