Re: [Qemu-devel] [PATCH] numa: Clean up query-memdev error handling, plug leak

2015-11-20 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Nov 20, 2015 at 05:24:02PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Fri, Nov 20, 2015 at 03:57:17PM +0100, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >> >> >> > On Fri, Nov 20, 2015 at 02:00:40PM +0100, Markus Armbr

Re: [Qemu-devel] [PATCH] numa: Clean up query-memdev error handling, plug leak

2015-11-20 Thread Eduardo Habkost
On Fri, Nov 20, 2015 at 05:24:02PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Fri, Nov 20, 2015 at 03:57:17PM +0100, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > On Fri, Nov 20, 2015 at 02:00:40PM +0100, Markus Armbruster wrote: > >> >> qmp_query_mem

Re: [Qemu-devel] [PATCH] numa: Clean up query-memdev error handling, plug leak

2015-11-20 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Nov 20, 2015 at 03:57:17PM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Fri, Nov 20, 2015 at 02:00:40PM +0100, Markus Armbruster wrote: >> >> qmp_query_memdev() doesn't fail. Instead, it returns an empty list. >> >> That's wrong. >> >>

Re: [Qemu-devel] [PATCH] numa: Clean up query-memdev error handling, plug leak

2015-11-20 Thread Eduardo Habkost
On Fri, Nov 20, 2015 at 03:57:17PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Fri, Nov 20, 2015 at 02:00:40PM +0100, Markus Armbruster wrote: > >> qmp_query_memdev() doesn't fail. Instead, it returns an empty list. > >> That's wrong. > >> > >> Two error paths: > >> > >>

Re: [Qemu-devel] [PATCH] numa: Clean up query-memdev error handling, plug leak

2015-11-20 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Nov 20, 2015 at 02:00:40PM +0100, Markus Armbruster wrote: >> qmp_query_memdev() doesn't fail. Instead, it returns an empty list. >> That's wrong. >> >> Two error paths: >> >> * When object_get_objects_root() returns null. It never does, so >> simply drop t

Re: [Qemu-devel] [PATCH] numa: Clean up query-memdev error handling, plug leak

2015-11-20 Thread Eduardo Habkost
On Fri, Nov 20, 2015 at 02:00:40PM +0100, Markus Armbruster wrote: > qmp_query_memdev() doesn't fail. Instead, it returns an empty list. > That's wrong. > > Two error paths: > > * When object_get_objects_root() returns null. It never does, so > simply drop the useless error handling. > > * W

[Qemu-devel] [PATCH] numa: Clean up query-memdev error handling, plug leak

2015-11-20 Thread Markus Armbruster
qmp_query_memdev() doesn't fail. Instead, it returns an empty list. That's wrong. Two error paths: * When object_get_objects_root() returns null. It never does, so simply drop the useless error handling. * When query_memdev() fails. This can happen, and the error to return is the one that