Re: [Qemu-devel] [PATCH] net: vmxnet: initialise local tx descriptor

2016-10-20 Thread Jason Wang
On 2016年10月19日 03:35, P J P wrote: Hello Jason, +-- On Thu, 11 Aug 2016, Dmitry Fleytman wrote --+ | Reviewed-by: Dmitry Fleytman | | > @@ -531,6 +531,7 @@ static void vmxnet3_complete_packet(VMXNET3State *s, int qidx, uint32_t tx_ridx) | > | > VMXNET3_RING_DUMP(VMW_RIPRN, "TXC", qidx

Re: [Qemu-devel] [PATCH] net: vmxnet: initialise local tx descriptor

2016-10-18 Thread P J P
Hello Jason, +-- On Thu, 11 Aug 2016, Dmitry Fleytman wrote --+ | Reviewed-by: Dmitry Fleytman | | > @@ -531,6 +531,7 @@ static void vmxnet3_complete_packet(VMXNET3State *s, int qidx, uint32_t tx_ridx) | > | > VMXNET3_RING_DUMP(VMW_RIPRN, "TXC", qidx, &s->txq_descr[qidx].comp_ring); | >

Re: [Qemu-devel] [PATCH] net: vmxnet: initialise local tx descriptor

2016-08-11 Thread Dmitry Fleytman
Reviewed-by: Dmitry Fleytman > On 10 Aug 2016, at 22:12 PM, P J P wrote: > > From: Li Qiang > > In Vmxnet3 device emulator while processing transmit(tx) queue, > when it reaches end of packet, it calls vmxnet3_complete_packet. > In that local 'txcq_descr' object is not initialised, which coul

[Qemu-devel] [PATCH] net: vmxnet: initialise local tx descriptor

2016-08-10 Thread P J P
From: Li Qiang In Vmxnet3 device emulator while processing transmit(tx) queue, when it reaches end of packet, it calls vmxnet3_complete_packet. In that local 'txcq_descr' object is not initialised, which could leak host memory bytes a guest. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit