Re: [Qemu-devel] [PATCH] net: tap-linux: Fix unhelpful error message

2011-10-28 Thread Stefan Hajnoczi
On Fri, Oct 14, 2011 at 03:05:10PM -0300, Luiz Capitulino wrote: > I'm getting: > > could not configure /dev/net/tun (tap%d): Operation not permitted > > When the ioctl() fails, ifr.ifr_name will most likely not be overwritten. > So we better only use it when ifname contains a string. > > Si

Re: [Qemu-devel] [PATCH] net: tap-linux: Fix unhelpful error message

2011-10-27 Thread Luiz Capitulino
On Fri, 14 Oct 2011 15:05:10 -0300 Luiz Capitulino wrote: > I'm getting: > > could not configure /dev/net/tun (tap%d): Operation not permitted > > When the ioctl() fails, ifr.ifr_name will most likely not be overwritten. > So we better only use it when ifname contains a string. I had forgo

[Qemu-devel] [PATCH] net: tap-linux: Fix unhelpful error message

2011-10-14 Thread Luiz Capitulino
I'm getting: could not configure /dev/net/tun (tap%d): Operation not permitted When the ioctl() fails, ifr.ifr_name will most likely not be overwritten. So we better only use it when ifname contains a string. Signed-off-by: Luiz Capitulino --- PS: Trivial tree candidate. net/tap-linux.c