Re: [Qemu-devel] [PATCH] net: split colo_compare_pkt_info into two trace events

2016-10-31 Thread Eric Blake
On 10/31/2016 06:42 AM, Alex Bennée wrote: > > Zhang Chen writes: >> It looks good for me, but it not the root cause of this bug. >> We better fix this in UST trace event codes > > I didn't get a chance to dig into the details but yes we need to confirm > if this is a limitation with UST or

Re: [Qemu-devel] [PATCH] net: split colo_compare_pkt_info into two trace events

2016-10-31 Thread Alex Bennée
Zhang Chen writes: > On 10/28/2016 09:25 PM, Alex Bennée wrote: >> It seems there is a limit to the number of arguments a UST trace event >> can take and at 11 the previous trace command broke the build. Split the >> trace into a src pkt and dst pkt trace to fix this. >> >> Signed-off-by: Alex B

Re: [Qemu-devel] [PATCH] net: split colo_compare_pkt_info into two trace events

2016-10-31 Thread Zhang Chen
On 10/28/2016 09:25 PM, Alex Bennée wrote: It seems there is a limit to the number of arguments a UST trace event can take and at 11 the previous trace command broke the build. Split the trace into a src pkt and dst pkt trace to fix this. Signed-off-by: Alex Bennée It looks good for me, but

Re: [Qemu-devel] [PATCH] net: split colo_compare_pkt_info into two trace events

2016-10-31 Thread Peter Maydell
On 28 October 2016 at 14:25, Alex Bennée wrote: > It seems there is a limit to the number of arguments a UST trace event > can take and at 11 the previous trace command broke the build. Split the > trace into a src pkt and dst pkt trace to fix this. > > Signed-off-by: Alex Bennée Applied to mast

[Qemu-devel] [PATCH] net: split colo_compare_pkt_info into two trace events

2016-10-28 Thread Alex Bennée
It seems there is a limit to the number of arguments a UST trace event can take and at 11 the previous trace command broke the build. Split the trace into a src pkt and dst pkt trace to fix this. Signed-off-by: Alex Bennée --- net/colo-compare.c | 21 +++-- net/trace-events |