Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 14:51, Marc-André Lureau wrote: > Hi > > - Original Message - >> >> >> On 11/07/2016 13:23, Jason Wang wrote: >>> >>> >>> On 2016年07月11日 17:18, Paolo Bonzini wrote: On 11/07/2016 11:06, Jason Wang wrote: > > On 2016年07月08日 23:27, Paolo Bonzini wrote: >

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-11 Thread Marc-André Lureau
Hi - Original Message - > > > On 11/07/2016 13:23, Jason Wang wrote: > > > > > > On 2016年07月11日 17:18, Paolo Bonzini wrote: > >> > >> On 11/07/2016 11:06, Jason Wang wrote: > >>> > >>> On 2016年07月08日 23:27, Paolo Bonzini wrote: > Otherwise, vhost-user causes a use-after-free. > >>

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 13:23, Jason Wang wrote: > > > On 2016年07月11日 17:18, Paolo Bonzini wrote: >> >> On 11/07/2016 11:06, Jason Wang wrote: >>> >>> On 2016年07月08日 23:27, Paolo Bonzini wrote: Otherwise, vhost-user causes a use-after-free. Signed-off-by: Paolo Bonzini --- vl

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-11 Thread Jason Wang
On 2016年07月11日 17:18, Paolo Bonzini wrote: On 11/07/2016 11:06, Jason Wang wrote: On 2016年07月08日 23:27, Paolo Bonzini wrote: Otherwise, vhost-user causes a use-after-free. Signed-off-by: Paolo Bonzini --- vl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-11 Thread Paolo Bonzini
On 11/07/2016 11:06, Jason Wang wrote: > > > On 2016年07月08日 23:27, Paolo Bonzini wrote: >> Otherwise, vhost-user causes a use-after-free. >> >> Signed-off-by: Paolo Bonzini >> --- >> vl.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/vl.c b/vl.c >> index

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-11 Thread Jason Wang
On 2016年07月08日 23:27, Paolo Bonzini wrote: Otherwise, vhost-user causes a use-after-free. Signed-off-by: Paolo Bonzini --- vl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index d0b9ff9..005162d 100644 --- a/vl.c +++ b/vl.c @@ -4327,9 +4327,6 @@ in

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-08 Thread Paolo Bonzini
On 08/07/2016 17:42, Marc-André Lureau wrote: > Alternatively, if it's better to keep the atexit(net_cleanup), we > could have atexit(qemu_chr_cleanup) here, so it's only called on > normal exit and after net_cleanup. No, atexit functions are called in LIFO order (which actually makes sense if y

Re: [Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-08 Thread Marc-André Lureau
Hi On Fri, Jul 8, 2016 at 5:27 PM, Paolo Bonzini wrote: > Otherwise, vhost-user causes a use-after-free. > > Signed-off-by: Paolo Bonzini Sorry I didn't see the criticals in make check after my patch... Thanks for fixing it this quickly > --- > vl.c | 6 +++--- > 1 file changed, 3 insertions(

[Qemu-devel] [PATCH] net: cleanup before character devices

2016-07-08 Thread Paolo Bonzini
Otherwise, vhost-user causes a use-after-free. Signed-off-by: Paolo Bonzini --- vl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index d0b9ff9..005162d 100644 --- a/vl.c +++ b/vl.c @@ -4327,9 +4327,6 @@ int main(int argc, char **argv, char **envp)