Re: [Qemu-devel] [PATCH] net: Reject non-netdevs in qmp_netdev_del()

2012-11-01 Thread Stefan Hajnoczi
On Wed, Oct 24, 2012 at 02:34:12PM +0200, Stefan Hajnoczi wrote: > The netdev_del command crashes when given a -net device, because it > calls qemu_opts_del(NULL). > > Check that this is a -netdev before attempting to delete it and the > QemuOpts. > > Note the subtle change from qemu_find_opts_er

[Qemu-devel] [PATCH] net: Reject non-netdevs in qmp_netdev_del()

2012-10-24 Thread Stefan Hajnoczi
The netdev_del command crashes when given a -net device, because it calls qemu_opts_del(NULL). Check that this is a -netdev before attempting to delete it and the QemuOpts. Note the subtle change from qemu_find_opts_err("netdev", errp) to qemu_find_opts_err("netdev", NULL). Since "netdev" is a b