Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

2015-12-04 Thread Markus Armbruster
阎淼 writes: > 2015-12-04 0:40 GMT+08:00 Markus Armbruster : >> Eric Blake writes: >> >>> On 12/02/2015 10:08 PM, Miao Yan wrote: Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init(). This will cause build error when debug level is raised in vmxnet3_debug.h (ena

Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

2015-12-04 Thread 阎淼
2015-12-04 0:40 GMT+08:00 Markus Armbruster : > Eric Blake writes: > >> On 12/02/2015 10:08 PM, Miao Yan wrote: >>> Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init(). >>> This will cause build error when debug level is raised in >>> vmxnet3_debug.h (enable all VMXNET3_DEBUG

Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

2015-12-03 Thread 阎淼
2015-12-04 14:58 GMT+08:00 阎淼 : > 2015-12-03 23:59 GMT+08:00 Eric Blake : >> On 12/02/2015 10:08 PM, Miao Yan wrote: >>> Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init(). >>> This will cause build error when debug level is raised in >>> vmxnet3_debug.h (enable all VMXNET3_D

Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

2015-12-03 Thread Jason Wang
On 12/03/2015 03:24 PM, Dmitry Fleytman wrote: > Acked-by: Dmitry Fleytman mailto:dmi...@daynix.com>> Applied in my -net for 2.5. Thanks > >> On 3 Dec 2015, at 07:08 AM, Miao Yan > > wrote: >> >> Macro MAC_FMT and MAC_ARG are not defined, but used in >> vmxnet3_ne

Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

2015-12-03 Thread Markus Armbruster
Eric Blake writes: > On 12/02/2015 10:08 PM, Miao Yan wrote: >> Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init(). >> This will cause build error when debug level is raised in >> vmxnet3_debug.h (enable all VMXNET3_DEBUG_xxx). >> >> Use VMXNET_MF and VXMNET_MA instead. >>

Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

2015-12-03 Thread Eric Blake
On 12/02/2015 10:08 PM, Miao Yan wrote: > Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init(). > This will cause build error when debug level is raised in > vmxnet3_debug.h (enable all VMXNET3_DEBUG_xxx). > > Use VMXNET_MF and VXMNET_MA instead. > > Signed-off-by: Miao Yan

[Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

2015-12-03 Thread Miao Yan
Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init(). This will cause build error when debug level is raised in vmxnet3_debug.h (enable all VMXNET3_DEBUG_xxx). Use VMXNET_MF and VXMNET_MA instead. Signed-off-by: Miao Yan --- hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insert

Re: [Qemu-devel] [PATCH] net/vmxnet3.c: fix a build error when enabling debug output

2015-12-02 Thread Dmitry Fleytman
Acked-by: Dmitry Fleytman mailto:dmi...@daynix.com>> > On 3 Dec 2015, at 07:08 AM, Miao Yan wrote: > > Macro MAC_FMT and MAC_ARG are not defined, but used in vmxnet3_net_init(). > This will cause build error when debug level is raised in > vmxnet3_debug.h (enable all VMXNET3_DEBUG_xxx). > > Use