Re: [Qemu-devel] [PATCH] nbd: simplify the nbd_request and nbd_reply structs

2016-06-13 Thread Eric Blake
On 06/13/2016 03:43 AM, Paolo Bonzini wrote: > These structs are never used to represent the bytes that go over the > network. The big-endian network data is built into a uint8_t array > in nbd_{receive,send}_{request,reply}. Remove the unused magic field, > reorder the struct to avoid holes, and

[Qemu-devel] [PATCH] nbd: simplify the nbd_request and nbd_reply structs

2016-06-13 Thread Paolo Bonzini
These structs are never used to represent the bytes that go over the network. The big-endian network data is built into a uint8_t array in nbd_{receive,send}_{request,reply}. Remove the unused magic field, reorder the struct to avoid holes, and remove the packed attribute. Signed-off-by: Paolo B