Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-11-16 Thread Anthony Liguori
On 11/04/2010 05:22 PM, Adam Lackorzynski wrote: A via -kernel supplied x86_64 ELF image is being started in 32bit mode. Detect and exit if a 64bit image has been supplied. Signed-off-by: Adam Lackorzynski Acked-by: Alexander Graf Applied. Thanks. Regards, Anthony Liguori --- hw/mul

[Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-11-04 Thread Adam Lackorzynski
A via -kernel supplied x86_64 ELF image is being started in 32bit mode. Detect and exit if a 64bit image has been supplied. Signed-off-by: Adam Lackorzynski Acked-by: Alexander Graf --- hw/multiboot.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/multiboot.c

[Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-09-25 Thread Adam Lackorzynski
A via -kernel supplied x86_64 ELF image is being started in 32bit mode. Detect and exit if a 64bit image has been supplied. Signed-off-by: Adam Lackorzynski Acked-by: Alexander Graf --- hw/multiboot.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/multiboot.c

[Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-09-02 Thread Adam Lackorzynski
A via -kernel supplied x86_64 ELF image is being started in 32bit mode. Detect and exit if a 64bit image has been supplied. Signed-off-by: Adam Lackorzynski Acked-by: Alexander Graf --- hw/multiboot.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/multiboot.c

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-20 Thread Rene Rebe
Hi, On Aug 19, 2010, at 2:49 PM, Adam Lackorzynski wrote: > > On Thu Aug 19, 2010 at 14:34:10 +0200, Alexander Graf wrote: >> >> On 19.08.2010, at 14:32, Adam Lackorzynski wrote: >> >>> >>> On Thu Aug 19, 2010 at 13:40:54 +0200, Alexander Graf wrote: On 19.08.2010, at 13:36, Adam L

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Avi Kivity
On 08/19/2010 05:10 PM, Alexander Graf wrote: We rely on the existing behaviour in kvm-unit-tests.git. Tests (.flat files) are 64-bit elf binaries that are loaded in 32-bit more and switch immediately to 64-bit. We can easily wrap them in a 32-bit elf, but that's a needless complication.

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Alexander Graf
On 19.08.2010, at 16:05, Avi Kivity wrote: > On 08/19/2010 04:57 PM, Alexander Graf wrote: >> >>> We rely on the existing behaviour in kvm-unit-tests.git. Tests (.flat >>> files) are 64-bit elf binaries that are loaded in 32-bit more and switch >>> immediately to 64-bit. >>> >>> We can easil

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Avi Kivity
On 08/19/2010 04:57 PM, Alexander Graf wrote: We rely on the existing behaviour in kvm-unit-tests.git. Tests (.flat files) are 64-bit elf binaries that are loaded in 32-bit more and switch immediately to 64-bit. We can easily wrap them in a 32-bit elf, but that's a needless complication.

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Alexander Graf
On 19.08.2010, at 15:02, Avi Kivity wrote: > On 08/19/2010 02:24 PM, Adam Lackorzynski wrote: >> A via -kernel supplied x86_64 ELF image is being started in 32bit mode. >> Detect and exit if a 64bit image has been supplied. >> >> >> >> diff --git a/hw/multiboot.c b/hw/multiboot.c >> index dc98

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Alexander Graf
On 19.08.2010, at 14:49, Adam Lackorzynski wrote: > > On Thu Aug 19, 2010 at 14:34:10 +0200, Alexander Graf wrote: >> >> On 19.08.2010, at 14:32, Adam Lackorzynski wrote: >> >>> >>> On Thu Aug 19, 2010 at 13:40:54 +0200, Alexander Graf wrote: On 19.08.2010, at 13:36, Adam Lackorzyn

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Avi Kivity
On 08/19/2010 02:24 PM, Adam Lackorzynski wrote: A via -kernel supplied x86_64 ELF image is being started in 32bit mode. Detect and exit if a 64bit image has been supplied. diff --git a/hw/multiboot.c b/hw/multiboot.c index dc980e6..e9dcbc9 100644 --- a/hw/multiboot.c +++ b/hw/multiboot.c @@

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Adam Lackorzynski
On Thu Aug 19, 2010 at 14:34:10 +0200, Alexander Graf wrote: > > On 19.08.2010, at 14:32, Adam Lackorzynski wrote: > > > > > On Thu Aug 19, 2010 at 13:40:54 +0200, Alexander Graf wrote: > >> > >> On 19.08.2010, at 13:36, Adam Lackorzynski wrote: > >> > >>> > >>> On Thu Aug 19, 2010 at 13:27:

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Alexander Graf
On 19.08.2010, at 14:32, Adam Lackorzynski wrote: > > On Thu Aug 19, 2010 at 13:40:54 +0200, Alexander Graf wrote: >> >> On 19.08.2010, at 13:36, Adam Lackorzynski wrote: >> >>> >>> On Thu Aug 19, 2010 at 13:27:32 +0200, Alexander Graf wrote: On 19.08.2010, at 13:24, Adam Lackorzyn

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Adam Lackorzynski
On Thu Aug 19, 2010 at 13:40:54 +0200, Alexander Graf wrote: > > On 19.08.2010, at 13:36, Adam Lackorzynski wrote: > > > > > On Thu Aug 19, 2010 at 13:27:32 +0200, Alexander Graf wrote: > >> > >> On 19.08.2010, at 13:24, Adam Lackorzynski wrote: > >> > >>> A via -kernel supplied x86_64 ELF im

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Adam Lackorzynski
On Thu Aug 19, 2010 at 13:27:32 +0200, Alexander Graf wrote: > > On 19.08.2010, at 13:24, Adam Lackorzynski wrote: > > > A via -kernel supplied x86_64 ELF image is being started in 32bit mode. > > Detect and exit if a 64bit image has been supplied. > > According to the multiboot spec, this is t

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Alexander Graf
On 19.08.2010, at 13:36, Adam Lackorzynski wrote: > > On Thu Aug 19, 2010 at 13:27:32 +0200, Alexander Graf wrote: >> >> On 19.08.2010, at 13:24, Adam Lackorzynski wrote: >> >>> A via -kernel supplied x86_64 ELF image is being started in 32bit mode. >>> Detect and exit if a 64bit image has bee

Re: [Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Alexander Graf
On 19.08.2010, at 13:24, Adam Lackorzynski wrote: > A via -kernel supplied x86_64 ELF image is being started in 32bit mode. > Detect and exit if a 64bit image has been supplied. According to the multiboot spec, this is the expected behavior, no? At least Xen does it that way... Alex

[Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-08-19 Thread Adam Lackorzynski
A via -kernel supplied x86_64 ELF image is being started in 32bit mode. Detect and exit if a 64bit image has been supplied. Signed-off-by: Adam Lackorzynski --- hw/multiboot.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/multiboot.c b/hw/multiboot.c index dc98