Re: [Qemu-devel] [PATCH] mptsas: Fix a migration compatible issue

2016-08-02 Thread Paolo Bonzini
> Before I send the fix, I did a quick test on linux as following: > > #include > #include > > int main() > { > printf("bool size = %d\n", sizeof(bool)); > } > > > then: > ./a.out > bool size = 1 > > and there is mptsas.c #include "qemu/osdep.h", osdep.h #include > > So, am I missing

Re: [Qemu-devel] [PATCH] mptsas: Fix a migration compatible issue

2016-08-02 Thread Cao jin
Hi On 08/01/2016 11:29 PM, Amit Shah wrote: On (Mon) 01 Aug 2016 [10:16:50], Paolo Bonzini wrote: @@ -1370,7 +1370,7 @@ static const VMStateDescription vmstate_mptsas = { .post_load = mptsas_post_load, .fields = (VMStateField[]) { VMSTATE_PCI_DEVICE(dev, MPTSASState

Re: [Qemu-devel] [PATCH] mptsas: Fix a migration compatible issue

2016-08-01 Thread Amit Shah
On (Mon) 01 Aug 2016 [10:16:50], Paolo Bonzini wrote: > > > On 26/07/2016 11:03, Cao jin wrote: > > My previous commit 2e2aa316 removed internal flag msi_in_use, which > > exists in vmstate, use VMSTATE_UNUSED for migration compatibility. > > > > Reported-by: Amit Shah > > Suggested-by: Amit Sh

Re: [Qemu-devel] [PATCH] mptsas: Fix a migration compatible issue

2016-08-01 Thread Paolo Bonzini
On 26/07/2016 11:03, Cao jin wrote: > My previous commit 2e2aa316 removed internal flag msi_in_use, which > exists in vmstate, use VMSTATE_UNUSED for migration compatibility. > > Reported-by: Amit Shah > Suggested-by: Amit Shah > Cc: Markus Armbruster > Cc: Marcel Apfelbaum > Cc: Paolo Bonzi

Re: [Qemu-devel] [PATCH] mptsas: Fix a migration compatible issue

2016-07-26 Thread Amit Shah
On (Tue) 26 Jul 2016 [17:03:23], Cao jin wrote: > My previous commit 2e2aa316 removed internal flag msi_in_use, which > exists in vmstate, use VMSTATE_UNUSED for migration compatibility. > > Reported-by: Amit Shah > Suggested-by: Amit Shah > Cc: Markus Armbruster > Cc: Marcel Apfelbaum > Cc: P

[Qemu-devel] [PATCH] mptsas: Fix a migration compatible issue

2016-07-26 Thread Cao jin
My previous commit 2e2aa316 removed internal flag msi_in_use, which exists in vmstate, use VMSTATE_UNUSED for migration compatibility. Reported-by: Amit Shah Suggested-by: Amit Shah Cc: Markus Armbruster Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Michael S. Tsirkin Cc: Amit Shah Signed-off-