Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2021-03-05 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Hmm. An idea. What we want: read more than one character at a time, as > it's inefficient. May be instead of modifying monitor_can_read() and > therefore influence monitor behavior in unpredictable way, we'd better > add a separate read-cache, and just read

Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2021-03-05 Thread Vladimir Sementsov-Ogievskiy
05.03.2021 19:13, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 05.03.2021 17:10, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 24.11.2020 18:44, Vladimir Sementsov-Ogievskiy wrote: Hi all! This patch isn't outdated, it applies on master with a little conf

Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2021-03-05 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 05.03.2021 17:10, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 24.11.2020 18:44, Vladimir Sementsov-Ogievskiy wrote: Hi all! This patch isn't outdated, it applies on master with a little conflict atomic_mb_re

Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2021-03-05 Thread Vladimir Sementsov-Ogievskiy
05.03.2021 17:10, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 24.11.2020 18:44, Vladimir Sementsov-Ogievskiy wrote: Hi all! This patch isn't outdated, it applies on master with a little conflict atomic_mb_read -> qatomic_mb_read We have new series "[PATCH v2 0/2] Increase

Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2021-03-05 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.11.2020 18:44, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> This patch isn't outdated, it applies on master with a little conflict >> atomic_mb_read -> qatomic_mb_read >> >> We have new series "[PATCH v2 0/2] Increase amount of data for monitor

Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2021-03-02 Thread Vladimir Sementsov-Ogievskiy
24.11.2020 18:44, Vladimir Sementsov-Ogievskiy wrote: Hi all! This patch isn't outdated, it applies on master with a little conflict atomic_mb_read -> qatomic_mb_read We have new series "[PATCH v2 0/2] Increase amount of data for monitor to read", but I do think that we've started from wrong

Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2020-11-24 Thread Vladimir Sementsov-Ogievskiy
Hi all! This patch isn't outdated, it applies on master with a little conflict atomic_mb_read -> qatomic_mb_read We have new series "[PATCH v2 0/2] Increase amount of data for monitor to read", but I do think that we've started from wrong point. And actually we should start from this old patc

Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2019-07-10 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Did this fall through the cracks? > > Denis Plotnikov writes: > > > Right now QMP and HMP monitors read 1 byte at a time from the socket, which > > is very inefficient. With 100+ VMs on the host this easily reasults in > > a lot of unnecessary sys

Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2019-07-03 Thread Denis Lunev
On 7/3/19 9:36 AM, Markus Armbruster wrote: > Did this fall through the cracks? > > Denis Plotnikov writes: > >> Right now QMP and HMP monitors read 1 byte at a time from the socket, which >> is very inefficient. With 100+ VMs on the host this easily reasults in >> a lot of unnecessary system call

Re: [Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2019-07-02 Thread Markus Armbruster
Did this fall through the cracks? Denis Plotnikov writes: > Right now QMP and HMP monitors read 1 byte at a time from the socket, which > is very inefficient. With 100+ VMs on the host this easily reasults in > a lot of unnecessary system calls and CPU usage in the system. Yes, reading one byte

[Qemu-devel] [PATCH] monitor: increase amount of data for monitor to read

2019-06-10 Thread Denis Plotnikov
Right now QMP and HMP monitors read 1 byte at a time from the socket, which is very inefficient. With 100+ VMs on the host this easily reasults in a lot of unnecessary system calls and CPU usage in the system. This patch changes the amount of data to read to 4096 bytes, which matches buffer size o