Re: [Qemu-devel] [PATCH] monitor: fix qmp_getfd() fd leak in error case

2014-04-25 Thread Luiz Capitulino
On Thu, 24 Apr 2014 13:58:18 +0200 Stefan Hajnoczi wrote: > qemu_chr_fe_get_msgfd() transfers ownership of the file descriptor to > the caller. Therefore all code paths in qmp_getfd() should either > register the file descriptor somewhere or close it. > > Signed-off-by: Stefan Hajnoczi Applie

Re: [Qemu-devel] [PATCH] monitor: fix qmp_getfd() fd leak in error case

2014-04-25 Thread Markus Armbruster
Stefan Hajnoczi writes: > qemu_chr_fe_get_msgfd() transfers ownership of the file descriptor to > the caller. Therefore all code paths in qmp_getfd() should either > register the file descriptor somewhere or close it. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Markus Armbruster

[Qemu-devel] [PATCH] monitor: fix qmp_getfd() fd leak in error case

2014-04-24 Thread Stefan Hajnoczi
qemu_chr_fe_get_msgfd() transfers ownership of the file descriptor to the caller. Therefore all code paths in qmp_getfd() should either register the file descriptor somewhere or close it. Signed-off-by: Stefan Hajnoczi --- monitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/monitor.c