Re: [Qemu-devel] [PATCH] monitor: fix double-free of request error

2018-07-06 Thread Peter Xu
On Fri, Jul 06, 2018 at 08:25:57AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Thu, Jul 05, 2018 at 06:42:01PM +0200, Marc-André Lureau wrote: > >> qmp_error_response() will free the given error. Fix double-free in > >> later qmp_request_free(). > >> > >> Signed-off-by: Marc-Andr

Re: [Qemu-devel] [PATCH] monitor: fix double-free of request error

2018-07-05 Thread Markus Armbruster
Peter Xu writes: > On Thu, Jul 05, 2018 at 06:42:01PM +0200, Marc-André Lureau wrote: >> qmp_error_response() will free the given error. Fix double-free in >> later qmp_request_free(). >> >> Signed-off-by: Marc-André Lureau > > Reviewed-by: Peter Xu > > And not related to current patch... > >>

Re: [Qemu-devel] [PATCH] monitor: fix double-free of request error

2018-07-05 Thread Markus Armbruster
Marc-André Lureau writes: > qmp_error_response() will free the given error. Fix double-free in > later qmp_request_free(). > > Signed-off-by: Marc-André Lureau Broken in commit 1cc37471525 by yours truly. I'll add that to the commit message when I apply. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH] monitor: fix double-free of request error

2018-07-05 Thread Peter Xu
On Thu, Jul 05, 2018 at 06:42:01PM +0200, Marc-André Lureau wrote: > qmp_error_response() will free the given error. Fix double-free in > later qmp_request_free(). > > Signed-off-by: Marc-André Lureau Reviewed-by: Peter Xu And not related to current patch... > --- > monitor.c | 1 + > 1 file

[Qemu-devel] [PATCH] monitor: fix double-free of request error

2018-07-05 Thread Marc-André Lureau
qmp_error_response() will free the given error. Fix double-free in later qmp_request_free(). Signed-off-by: Marc-André Lureau --- monitor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/monitor.c b/monitor.c index 3c9c97b73f..7af1f18d13 100644 --- a/monitor.c +++ b/monitor.c @@ -4186,6 +41