Re: [Qemu-devel] [PATCH] migration: fix migration shutdown

2019-04-08 Thread Yury Kotov
Hi, I've sent another patch to fix this UAF: "migration: Fix use-after-free during process exit" It's more simple and fixes only the regression. Regards, Yury 05.04.2019, 12:07, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  03.04.2019, 22:06, "Dr. David Alan G

Re: [Qemu-devel] [PATCH] migration: fix migration shutdown

2019-04-05 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > 03.04.2019, 22:06, "Dr. David Alan Gilbert" : > > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: > >>  It fixes heap-use-after-free which was found by clang's ASAN. > >> > >>  Control flow of this use-after-free: > >>  main_thread: > >>  * Got

Re: [Qemu-devel] [PATCH] migration: fix migration shutdown

2019-04-04 Thread Yury Kotov
03.04.2019, 22:06, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  It fixes heap-use-after-free which was found by clang's ASAN. >> >>  Control flow of this use-after-free: >>  main_thread: >>  * Got SIGTERM and completes main loop >>  * Calls migration_shut

Re: [Qemu-devel] [PATCH] migration: fix migration shutdown

2019-04-03 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > It fixes heap-use-after-free which was found by clang's ASAN. > > Control flow of this use-after-free: > main_thread: > * Got SIGTERM and completes main loop > * Calls migration_shutdown > - migrate_fd_cancel (so, migration_thread beg

[Qemu-devel] [PATCH] migration: fix migration shutdown

2019-04-03 Thread Yury Kotov
It fixes heap-use-after-free which was found by clang's ASAN. Control flow of this use-after-free: main_thread: * Got SIGTERM and completes main loop * Calls migration_shutdown - migrate_fd_cancel (so, migration_thread begins to complete) - object_unref(OBJECT(current_migration