On Thu, Aug 01, 2019 at 03:58:54PM +0800, Ivan Ren wrote:
>>>- * Here we didn't set RAMBlock.bmap simply because it is
>already
>>>- * set in ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION] in
>>>- * ram_block_add, and that's where we'll sync the dirty
>bitmaps.
>>
>>- * Here we didn't set RAMBlock.bmap simply because it is
already
>>- * set in ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION] in
>>- * ram_block_add, and that's where we'll sync the dirty
bitmaps.
>>- * Here setting RAMBlock.bmap would be fine too bu
Thanks, I didn't notice this case.
On Sun, Jul 14, 2019 at 10:51:19PM +0800, Ivan Ren wrote:
>Reproduce the problem:
>migrate
>migrate_cancel
>migrate
>
>Error happen for memory migration
>
>The reason as follows:
>1. qemu start, ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION] all set to
> 1 by a
* Peter Xu (zh...@redhat.com) wrote:
> On Sun, Jul 14, 2019 at 10:51:19PM +0800, Ivan Ren wrote:
> > Reproduce the problem:
> > migrate
> > migrate_cancel
> > migrate
> >
> > Error happen for memory migration
>
> Can mention "this mostly revert 0315851938 but with comments kept"
> when merge...
>
* Ivan Ren (reny...@gmail.com) wrote:
> Reproduce the problem:
> migrate
> migrate_cancel
> migrate
>
> Error happen for memory migration
Can we fix this by just reverting 03158519384 ?
Dave
> The reason as follows:
> 1. qemu start, ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION] all set to
>
On Sun, Jul 14, 2019 at 10:51:19PM +0800, Ivan Ren wrote:
> Reproduce the problem:
> migrate
> migrate_cancel
> migrate
>
> Error happen for memory migration
Can mention "this mostly revert 0315851938 but with comments kept"
when merge...
>
> The reason as follows:
> 1. qemu start, ram_list.dir
Reproduce the problem:
migrate
migrate_cancel
migrate
Error happen for memory migration
The reason as follows:
1. qemu start, ram_list.dirty_memory[DIRTY_MEMORY_MIGRATION] all set to
1 by a series of cpu_physical_memory_set_dirty_range
2. migration start:ram_init_bitmaps
- memory_global_dir
