Re: [Qemu-devel] [PATCH] migration: Improve QMP documentation

2013-02-22 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >>> I'm confused. Do you mean pages that are entirely filled with the same >>> byte? Or pages with contents identical to some other, non-duplicate >>> page? >> >> It is a page full of zeros. Yes, we can have pages full of any other >> char, th

Re: [Qemu-devel] [PATCH] migration: Improve QMP documentation

2013-02-22 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> Juan Quintela writes: >> >>> query-migrate >>> - >>> >>> + >>> Migration status. >>> >>> Return a json-object. If migration is active there will be another >>> json-object >> >> Extra blank line; please drop this hunk. > > than

Re: [Qemu-devel] [PATCH] migration: Improve QMP documentation

2013-02-22 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> query-migrate >> - >> >> + >> Migration status. >> >> Return a json-object. If migration is active there will be another >> json-object > > Extra blank line; please drop this hunk. thanks. > >> @@ -2438,25 +2439,34 @@ The ma

Re: [Qemu-devel] [PATCH] migration: Improve QMP documentation

2013-02-22 Thread Markus Armbruster
Juan Quintela writes: > Signed-off-by: Juan Quintela > --- > qmp-commands.hx | 50 ++ > 1 file changed, 30 insertions(+), 20 deletions(-) > > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 799adea..6d037bd 100644 > --- a/qmp-commands.hx >

[Qemu-devel] [PATCH] migration: Improve QMP documentation

2013-02-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- qmp-commands.hx | 50 ++ 1 file changed, 30 insertions(+), 20 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index 799adea..6d037bd 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -644,7 +644,7 @@