Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-05-21 Thread Yury Kotov
Ping 14.05.2019, 12:36, "Yury Kotov" : > Ping > > 18.04.2019, 20:46, "Yury Kotov" : >>  18.04.2019, 20:01, "Dr. David Alan Gilbert" : >>>   * Yury Kotov (yury-ko...@yandex-team.ru) wrote:    18.04.2019, 19:03, "Dr. David Alan Gilbert" :    > * Yury Kotov (yury-ko...@yandex-team.ru) wrote

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-05-14 Thread Yury Kotov
Ping 18.04.2019, 20:46, "Yury Kotov" : > 18.04.2019, 20:01, "Dr. David Alan Gilbert" : >>  * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>>   18.04.2019, 19:03, "Dr. David Alan Gilbert" : >>>   > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>>   >>  18.04.2019, 17:20, "Dr. David Alan Gilber

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-18 Thread Yury Kotov
18.04.2019, 20:01, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  18.04.2019, 19:03, "Dr. David Alan Gilbert" : >>  > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  >>  18.04.2019, 17:20, "Dr. David Alan Gilbert" : >>  >>  > * Yury Kotov (yury-ko...@yandex-tea

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-18 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > 18.04.2019, 19:03, "Dr. David Alan Gilbert" : > > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: > >>  18.04.2019, 17:20, "Dr. David Alan Gilbert" : > >>  > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: > >>  >>  15.04.2019, 14:30, "Dr. David Ala

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-18 Thread Yury Kotov
18.04.2019, 19:03, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  18.04.2019, 17:20, "Dr. David Alan Gilbert" : >>  > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  >>  15.04.2019, 14:30, "Dr. David Alan Gilbert" : >>  >>  > * Daniel P. Berrangé (berra...@redh

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-18 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > 18.04.2019, 17:20, "Dr. David Alan Gilbert" : > > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: > >>  15.04.2019, 14:30, "Dr. David Alan Gilbert" : > >>  > * Daniel P. Berrangé (berra...@redhat.com) wrote: > >>  >>  On Mon, Apr 15, 2019 at 12:15:1

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-18 Thread Yury Kotov
18.04.2019, 17:20, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  15.04.2019, 14:30, "Dr. David Alan Gilbert" : >>  > * Daniel P. Berrangé (berra...@redhat.com) wrote: >>  >>  On Mon, Apr 15, 2019 at 12:15:12PM +0100, Dr. David Alan Gilbert wrote: >>  >>  > * Danie

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-18 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > 15.04.2019, 14:30, "Dr. David Alan Gilbert" : > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > >>  On Mon, Apr 15, 2019 at 12:15:12PM +0100, Dr. David Alan Gilbert wrote: > >>  > * Daniel P. Berrangé (berra...@redhat.com) wrote: > >>  > > On

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-16 Thread Yury Kotov
15.04.2019, 14:30, "Dr. David Alan Gilbert" : > * Daniel P. Berrangé (berra...@redhat.com) wrote: >>  On Mon, Apr 15, 2019 at 12:15:12PM +0100, Dr. David Alan Gilbert wrote: >>  > * Daniel P. Berrangé (berra...@redhat.com) wrote: >>  > > On Mon, Apr 15, 2019 at 01:33:21PM +0300, Yury Kotov wrote: >

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-16 Thread Yury Kotov
15.04.2019, 15:21, "Yury Kotov" : > 15.04.2019, 14:30, "Dr. David Alan Gilbert" : >>  * Daniel P. Berrangé (berra...@redhat.com) wrote: >>>   On Mon, Apr 15, 2019 at 12:15:12PM +0100, Dr. David Alan Gilbert wrote: >>>   > * Daniel P. Berrangé (berra...@redhat.com) wrote: >>>   > > On Mon, Apr 15, 2

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-15 Thread Yury Kotov
15.04.2019, 14:30, "Dr. David Alan Gilbert" : > * Daniel P. Berrangé (berra...@redhat.com) wrote: >>  On Mon, Apr 15, 2019 at 12:15:12PM +0100, Dr. David Alan Gilbert wrote: >>  > * Daniel P. Berrangé (berra...@redhat.com) wrote: >>  > > On Mon, Apr 15, 2019 at 01:33:21PM +0300, Yury Kotov wrote: >

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Apr 15, 2019 at 12:15:12PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > > On Mon, Apr 15, 2019 at 01:33:21PM +0300, Yury Kotov wrote: > > > > 15.04.2019, 13:25, "Daniel P. Berrangé" : > > >

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-15 Thread Daniel P . Berrangé
On Mon, Apr 15, 2019 at 12:15:12PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Mon, Apr 15, 2019 at 01:33:21PM +0300, Yury Kotov wrote: > > > 15.04.2019, 13:25, "Daniel P. Berrangé" : > > > > On Mon, Apr 15, 2019 at 01:17:06PM +0300, Yury Kotov wr

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-15 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Apr 15, 2019 at 01:33:21PM +0300, Yury Kotov wrote: > > 15.04.2019, 13:25, "Daniel P. Berrangé" : > > > On Mon, Apr 15, 2019 at 01:17:06PM +0300, Yury Kotov wrote: > > >>  15.04.2019, 13:11, "Daniel P. Berrangé" : > > >>  > On Mon, Apr 15,

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-15 Thread Daniel P . Berrangé
On Mon, Apr 15, 2019 at 01:33:21PM +0300, Yury Kotov wrote: > 15.04.2019, 13:25, "Daniel P. Berrangé" : > > On Mon, Apr 15, 2019 at 01:17:06PM +0300, Yury Kotov wrote: > >>  15.04.2019, 13:11, "Daniel P. Berrangé" : > >>  > On Mon, Apr 15, 2019 at 12:50:08PM +0300, Yury Kotov wrote: > >>  >>  Hi, >

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-15 Thread Yury Kotov
15.04.2019, 13:25, "Daniel P. Berrangé" : > On Mon, Apr 15, 2019 at 01:17:06PM +0300, Yury Kotov wrote: >>  15.04.2019, 13:11, "Daniel P. Berrangé" : >>  > On Mon, Apr 15, 2019 at 12:50:08PM +0300, Yury Kotov wrote: >>  >>  Hi, >>  >> >>  >>  Just to clarify. I see two possible solutions: >>  >> >>

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-15 Thread Daniel P . Berrangé
On Mon, Apr 15, 2019 at 01:17:06PM +0300, Yury Kotov wrote: > 15.04.2019, 13:11, "Daniel P. Berrangé" : > > On Mon, Apr 15, 2019 at 12:50:08PM +0300, Yury Kotov wrote: > >>  Hi, > >> > >>  Just to clarify. I see two possible solutions: > >> > >>  1) Since the migration code doesn't receive fd, it i

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-15 Thread Yury Kotov
15.04.2019, 13:17, "Yury Kotov" : > 15.04.2019, 13:11, "Daniel P. Berrangé" : >>  On Mon, Apr 15, 2019 at 12:50:08PM +0300, Yury Kotov wrote: >>>   Hi, >>> >>>   Just to clarify. I see two possible solutions: >>> >>>   1) Since the migration code doesn't receive fd, it isn't responsible for >>>   c

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-15 Thread Yury Kotov
15.04.2019, 13:11, "Daniel P. Berrangé" : > On Mon, Apr 15, 2019 at 12:50:08PM +0300, Yury Kotov wrote: >>  Hi, >> >>  Just to clarify. I see two possible solutions: >> >>  1) Since the migration code doesn't receive fd, it isn't responsible for >>  closing it. So, it may be better to use migrate_f

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-15 Thread Daniel P . Berrangé
On Mon, Apr 15, 2019 at 12:50:08PM +0300, Yury Kotov wrote: > Hi, > > Just to clarify. I see two possible solutions: > > 1) Since the migration code doesn't receive fd, it isn't responsible for > closing it. So, it may be better to use migrate_fd_param for both > incoming/outgoing and add dupping

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-15 Thread Yury Kotov
Hi, Just to clarify. I see two possible solutions: 1) Since the migration code doesn't receive fd, it isn't responsible for closing it. So, it may be better to use migrate_fd_param for both incoming/outgoing and add dupping for migrate_fd_param. Thus, clients must close the fd themselves. But exi

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-11 Thread Yury Kotov
11.04.2019, 15:39, "Daniel P. Berrangé" : > On Thu, Apr 11, 2019 at 03:31:43PM +0300, Yury Kotov wrote: >>  11.04.2019, 15:04, "Daniel P. Berrangé" : >>  > On Wed, Apr 10, 2019 at 12:26:52PM +0300, Yury Kotov wrote: >>  >>  Currently such case is possible for incoming: >>  >>  QMP: add-fd (fdset =

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-11 Thread Daniel P . Berrangé
On Thu, Apr 11, 2019 at 03:31:43PM +0300, Yury Kotov wrote: > 11.04.2019, 15:04, "Daniel P. Berrangé" : > > On Wed, Apr 10, 2019 at 12:26:52PM +0300, Yury Kotov wrote: > >>  Currently such case is possible for incoming: > >>  QMP: add-fd (fdset = 0, fd of some file): > >>  adds fd to fdset 0 an

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-11 Thread Yury Kotov
11.04.2019, 15:04, "Daniel P. Berrangé" : > On Wed, Apr 10, 2019 at 12:26:52PM +0300, Yury Kotov wrote: >>  Currently such case is possible for incoming: >>  QMP: add-fd (fdset = 0, fd of some file): >>  adds fd to fdset 0 and returns QEMU's fd (e.g. 33) >>  QMP: migrate-incoming (uri = "fd:33"

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-11 Thread Daniel P . Berrangé
On Wed, Apr 10, 2019 at 12:26:52PM +0300, Yury Kotov wrote: > Currently such case is possible for incoming: > QMP: add-fd (fdset = 0, fd of some file): > adds fd to fdset 0 and returns QEMU's fd (e.g. 33) > QMP: migrate-incoming (uri = "fd:33"): fd is stored in QIOChannel *ioc > ... > Incoming

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-10 Thread Yury Kotov
Hi, 10.04.2019, 16:58, "Dr. David Alan Gilbert" : > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: >>  Currently such case is possible for incoming: >>  QMP: add-fd (fdset = 0, fd of some file): >>  adds fd to fdset 0 and returns QEMU's fd (e.g. 33) >>  QMP: migrate-incoming (uri = "fd:33"):

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-10 Thread Dr. David Alan Gilbert
* Yury Kotov (yury-ko...@yandex-team.ru) wrote: > Currently such case is possible for incoming: > QMP: add-fd (fdset = 0, fd of some file): > adds fd to fdset 0 and returns QEMU's fd (e.g. 33) > QMP: migrate-incoming (uri = "fd:33"): fd is stored in QIOChannel *ioc > ... > Incoming migration co

Re: [Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190410092652.22616-1-yury-ko...@yandex-team.ru/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEG

[Qemu-devel] [PATCH] migration: Fix handling fd protocol

2019-04-10 Thread Yury Kotov
Currently such case is possible for incoming: QMP: add-fd (fdset = 0, fd of some file): adds fd to fdset 0 and returns QEMU's fd (e.g. 33) QMP: migrate-incoming (uri = "fd:33"): fd is stored in QIOChannel *ioc ... Incoming migration completes and unrefs ioc -> close(33) QMP: remove-fd (fdset =