[Qemu-devel] [PATCH] microblaze: fix build on Ubuntu Hardy

2010-04-09 Thread Thomas Monjalon
From: Thomas Monjalon Using GCC-4.2.4-1ubuntu4, there were 3 warnings: microblaze-dis.c:829: warning: format '%04x' expects type 'unsigned int', but argument 4 has type 'long unsigned int' microblaze-dis.c:962: warning: format '%04x' expects type 'unsigned int', but argument 4 h

Re: [Qemu-devel] [PATCH] microblaze: fix build on Ubuntu Hardy

2010-04-08 Thread Paul Brook
> { > - fprintf_ftype fprintf = info->fprintf_func; >void * stream = info->stream; I'm pretty sure this is not the correct fix. "Fix a warning" is not sufficient justification for any change. We need to understand what was wrong with the old code, and why the new code is

[Qemu-devel] [PATCH] microblaze: fix build on Ubuntu Hardy

2010-04-08 Thread Thomas Monjalon
From: Thomas Monjalon Using GCC-4.2.4-1ubuntu4, there were 3 warnings. Signed-off-by: Thomas Monjalon --- microblaze-dis.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/microblaze-dis.c b/microblaze-dis.c index b26572f..698ea7b 100644 --- a/microblaze-dis.c +++ b