Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Gerd Hoffmann
On 06/17/13 11:30, Alon Levy wrote: > But on the other hand if this is something that would be acceptable now > and having proper Async error handling is not forthcoming (why btw? is > anyone working on it) . But it would become baggage later on.. Don't think it is too bad, RfC patches will go out

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Luiz Capitulino
On Mon, 17 Jun 2013 08:06:58 +0200 Gerd Hoffmann wrote: > Hmm, while thinking about it: There is another screendump change in the > pipeline: allow screen dumps from *any* device. So, I think this is > actually a very good reason to implement a new screendump command as I > think we can kill tw

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Luiz Capitulino
On Fri, 14 Jun 2013 19:55:21 -0400 Alon Levy wrote: > On Fri, 2013-06-14 at 13:21 -0500, Anthony Liguori wrote: > > Alon Levy writes: > > > > > This fixes the broken screendump behavior for qxl devices in native mode > > > since 81fb6f1504fb9ef71f2382f44af34756668296e8. > > > > > > Note: due to

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-17 Thread Alon Levy
On Mon, 2013-06-17 at 08:06 +0200, Gerd Hoffmann wrote: > Hi, > > > Why is QXL unable to do a synchronous screendump? > > Lazy rendering. By default spice-server doesn't render anything, it > just sends over all drawing ops to the client who does the actual > rendering for the user. > > qemu

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-16 Thread Gerd Hoffmann
Hi, > Why is QXL unable to do a synchronous screendump? Lazy rendering. By default spice-server doesn't render anything, it just sends over all drawing ops to the client who does the actual rendering for the user. qemu can kick spice-server and ask it to render stuff locally if needed. Happe

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-14 Thread Alon Levy
On Fri, 2013-06-14 at 13:21 -0500, Anthony Liguori wrote: > Alon Levy writes: > > > This fixes the broken screendump behavior for qxl devices in native mode > > since 81fb6f1504fb9ef71f2382f44af34756668296e8. > > > > Note: due to QAPI not generating async commands yet I had to remove the > > sche

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-14 Thread Anthony Liguori
Alon Levy writes: > This fixes the broken screendump behavior for qxl devices in native mode > since 81fb6f1504fb9ef71f2382f44af34756668296e8. > > Note: due to QAPI not generating async commands yet I had to remove the > schema screendump definition. > > Related RHBZ: 973374 > This patch is not e

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-14 Thread Alon Levy
> > Hi, > > > > > Note: due to QAPI not generating async commands yet I had to remove the > > > schema screendump definition. > > > > Hmm, that will break libvirt I suspect. Guess this one has to wait > > until QAPI gained proper async command support. > > It doesn't break anything. I've tested

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-14 Thread Alon Levy
> Hi, > > > Note: due to QAPI not generating async commands yet I had to remove the > > schema screendump definition. > > Hmm, that will break libvirt I suspect. Guess this one has to wait > until QAPI gained proper async command support. It doesn't break anything. I've tested, and here is the

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-14 Thread Gerd Hoffmann
Hi, > Note: due to QAPI not generating async commands yet I had to remove the > schema screendump definition. Hmm, that will break libvirt I suspect. Guess this one has to wait until QAPI gained proper async command support. cheers, Gerd

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-13 Thread Alon Levy
> Il 13/06/2013 15:27, Alon Levy ha scritto: > > This fixes the broken screendump behavior for qxl devices in native mode > > since 81fb6f1504fb9ef71f2382f44af34756668296e8. > > > > Note: due to QAPI not generating async commands yet I had to remove the > > schema screendump definition. > > > > R

Re: [Qemu-devel] [PATCH] make screendump an async command

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 15:27, Alon Levy ha scritto: > This fixes the broken screendump behavior for qxl devices in native mode > since 81fb6f1504fb9ef71f2382f44af34756668296e8. > > Note: due to QAPI not generating async commands yet I had to remove the > schema screendump definition. > > Related RHBZ: 973

[Qemu-devel] [PATCH] make screendump an async command

2013-06-13 Thread Alon Levy
This fixes the broken screendump behavior for qxl devices in native mode since 81fb6f1504fb9ef71f2382f44af34756668296e8. Note: due to QAPI not generating async commands yet I had to remove the schema screendump definition. Related RHBZ: 973374 This patch is not enough to fix said bz, with the lin