Re: [Qemu-devel] [PATCH] linux-user: fix readlink handling with magic exe symlink

2014-08-08 Thread Mike Frysinger
please don't take this the wrong way, but i don't see how any of your comments are relevant. i didn't say "POSIX" anywhere (which isn't to say your outline of POSIX semantics are incorrect), but the QEMU linux-user layer has nothing to do with POSIX. the linux-user layer in QEMU implements the

Re: [Qemu-devel] [PATCH] linux-user: fix readlink handling with magic exe symlink

2014-08-08 Thread Eric Blake
On 08/07/2014 06:40 PM, Mike Frysinger wrote: > From: Mike Frysinger > > The current code always returns the length of the path when it should > be returning the number of bytes it wrote to the output string. That is indeed a bug. > > Further, readlink is not supposed to append a NUL byte, but

[Qemu-devel] [PATCH] linux-user: fix readlink handling with magic exe symlink

2014-08-07 Thread Mike Frysinger
From: Mike Frysinger The current code always returns the length of the path when it should be returning the number of bytes it wrote to the output string. Further, readlink is not supposed to append a NUL byte, but the current snprintf logic will always do just that. Even further, if you pass i