Re: [Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-06-01 Thread Alexander Graf
On 01.06.2012, at 04:17, Peter Maydell wrote: > On 1 June 2012 02:45, Alexander Graf wrote: >> On 01.06.2012, at 03:39, Peter Maydell wrote: >>> On 1 June 2012 02:16, Alexander Graf wrote: On 01.06.2012, at 02:44, Peter Maydell wrote: > So in the multithreaded case do all the thread s

Re: [Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Peter Maydell
On 1 June 2012 02:45, Alexander Graf wrote: > On 01.06.2012, at 03:39, Peter Maydell wrote: >> On 1 June 2012 02:16, Alexander Graf wrote: >>> On 01.06.2012, at 02:44, Peter Maydell wrote: So in the multithreaded case do all the thread stacks live in this one mapping, or do the non-pri

Re: [Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Alexander Graf
On 01.06.2012, at 03:39, Peter Maydell wrote: > On 1 June 2012 02:16, Alexander Graf wrote: >> On 01.06.2012, at 02:44, Peter Maydell wrote: >>> So in the multithreaded case do all the thread stacks live >>> in this one mapping, or do the non-primary thread stacks >>> live in a standard mmap'd

Re: [Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Peter Maydell
On 1 June 2012 02:16, Alexander Graf wrote: > On 01.06.2012, at 02:44, Peter Maydell wrote: >> So in the multithreaded case do all the thread stacks live >> in this one mapping, or do the non-primary thread stacks >> live in a standard mmap'd mapping? > > I thought /proc/self/maps always shows the

Re: [Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Alexander Graf
On 01.06.2012, at 02:44, Peter Maydell wrote: > On 30 May 2012 13:45, Alexander Graf wrote: >> When reading our faked /proc/self/maps from a secondary thread, >> we get an invalid stack entry. This is because ts->stack_base is not >> initialized in non-primary threads. >> >> However, ts->info i

Re: [Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Peter Maydell
On 30 May 2012 13:45, Alexander Graf wrote: > When reading our faked /proc/self/maps from a secondary thread, > we get an invalid stack entry. This is because ts->stack_base is not > initialized in non-primary threads. > > However, ts->info is, and the stack layout information we're looking > for

[Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Alexander Graf
When reading our faked /proc/self/maps from a secondary thread, we get an invalid stack entry. This is because ts->stack_base is not initialized in non-primary threads. However, ts->info is, and the stack layout information we're looking for is there too. So let's use that one instead! Signed-off