Re: [Qemu-devel] [PATCH] linux-user: correctly pack target_epoll_event for i386 target

2016-07-23 Thread Icenowy Zheng
22.07.2016, 23:06, "Peter Maydell" : > On 22 July 2016 at 03:30, Icenowy Zheng wrote: >>  According to comments in /usr/include/linux/eventpoll.h, x86_64 have >>  the same memory layout of struct target_epoll_event as i386. So on a >>  aligned host, if x86_64 should be packed, i386 will also nee

Re: [Qemu-devel] [PATCH] linux-user: correctly pack target_epoll_event for i386 target

2016-07-22 Thread Peter Maydell
On 22 July 2016 at 03:30, Icenowy Zheng wrote: > According to comments in /usr/include/linux/eventpoll.h, x86_64 have > the same memory layout of struct target_epoll_event as i386. So on a > aligned host, if x86_64 should be packed, i386 will also need. > > This has been tested with a i386 guest o

[Qemu-devel] [PATCH] linux-user: correctly pack target_epoll_event for i386 target

2016-07-21 Thread Icenowy Zheng
According to comments in /usr/include/linux/eventpoll.h, x86_64 have the same memory layout of struct target_epoll_event as i386. So on a aligned host, if x86_64 should be packed, i386 will also need. This has been tested with a i386 guest on an arm host: without the patch, wineserver crashes (cor