Re: [Qemu-devel] [PATCH] linux-user: correct semctl() and shmctl()

2013-01-20 Thread Peter Maydell
On 20 January 2013 21:12, Laurent Vivier wrote: > case GETALL: > case SETALL: > -err = target_to_host_semarray(semid, &array, target_su.array); > +err = target_to_host_semarray(semid, &array, > + tswapal(target_su->ar

[Qemu-devel] [PATCH] linux-user: correct semctl() and shmctl()

2013-01-20 Thread Laurent Vivier
The parameter "union semun" of semctl() is not a value but a pointer to the value. Moreover, all fields of target_su must be swapped (if needed). The third argument of shmctl is a pointer. WITHOUT this patch: $ ipcs kernel not configured for shared memory qemu: uncaught target signal 11 (Segm

Re: [Qemu-devel] [PATCH] linux-user: correct semctl() and shmctl()

2013-01-01 Thread Peter Maydell
On 20 December 2012 20:58, Laurent Vivier wrote: > The parameter "union semun" of semctl() is not a value > but a pointer to the value. > @@ -3161,10 +3163,16 @@ static abi_long do_ipc(unsigned int call, int first, > ret = get_errno(semget(first, second, third)); > break; > > -

Re: [Qemu-devel] [PATCH] linux-user: correct semctl() and shmctl()

2013-01-01 Thread Laurent Vivier
Ping ! Le jeudi 20 décembre 2012 à 21:58 +0100, Laurent Vivier a écrit : > The parameter "union semun" of semctl() is not a value > but a pointer to the value. > > Moreover, all fields of target_su must be swapped (if needed). > > The third argument of shmctl is a pointer. > > WITHOUT this patc

[Qemu-devel] [PATCH] linux-user: correct semctl() and shmctl()

2012-12-20 Thread Laurent Vivier
The parameter "union semun" of semctl() is not a value but a pointer to the value. Moreover, all fields of target_su must be swapped (if needed). The third argument of shmctl is a pointer. WITHOUT this patch: $ ipcs kernel not configured for shared memory qemu: uncaught target signal 11 (Segm