Re: [Qemu-devel] [PATCH] linux-user: Enable sigaltstack syscall for sh4

2015-11-19 Thread Peter Maydell
On 19 November 2015 at 12:20, Laurent Vivier wrote: > On 19/11/2015 12:15, Peter Maydell wrote: >> (Incidentally the only targets other than SH4 not listed in >> this ifdef are CRIS, Microblaze, TileGX and Unicore32. >> Maybe we should just go ahead and remove the ifdef entirely, >> if do_sigaltst

Re: [Qemu-devel] [PATCH] linux-user: Enable sigaltstack syscall for sh4

2015-11-19 Thread John Paul Adrian Glaubitz
On 11/19/2015 01:20 PM, Laurent Vivier wrote: > I don't know if these targets have a lot of users. At least for SH4, we > can enable it and see if someone is screaming (I like the "crash-test > method" :) ). I think Adrian will take care of this (and I can help). Exactly :). -- .''`. John Paul

Re: [Qemu-devel] [PATCH] linux-user: Enable sigaltstack syscall for sh4

2015-11-19 Thread Laurent Vivier
On 19/11/2015 12:15, Peter Maydell wrote: > On 19 November 2015 at 10:22, Laurent Vivier wrote: >> Hi, >> >> On 19/11/2015 10:28, John Paul Adrian Glaubitz wrote: >>> On 11/19/2015 10:17 AM, Peter Maydell wrote: Unfortunately this isn't sufficient. You also need to add the code to the

Re: [Qemu-devel] [PATCH] linux-user: Enable sigaltstack syscall for sh4

2015-11-19 Thread Peter Maydell
On 19 November 2015 at 10:22, Laurent Vivier wrote: > Hi, > > On 19/11/2015 10:28, John Paul Adrian Glaubitz wrote: >> On 11/19/2015 10:17 AM, Peter Maydell wrote: >>> Unfortunately this isn't sufficient. You also need to add >>> the code to the sh4-specific functions in linux-user/signal.c >>> wh

Re: [Qemu-devel] [PATCH] linux-user: Enable sigaltstack syscall for sh4

2015-11-19 Thread Laurent Vivier
Hi, On 19/11/2015 10:28, John Paul Adrian Glaubitz wrote: > On 11/19/2015 10:17 AM, Peter Maydell wrote: >> Unfortunately this isn't sufficient. You also need to add >> the code to the sh4-specific functions in linux-user/signal.c >> which honours the requested sigaltstack when taking and returnin

Re: [Qemu-devel] [PATCH] linux-user: Enable sigaltstack syscall for sh4

2015-11-19 Thread John Paul Adrian Glaubitz
On 11/19/2015 10:17 AM, Peter Maydell wrote: > Unfortunately this isn't sufficient. You also need to add > the code to the sh4-specific functions in linux-user/signal.c > which honours the requested sigaltstack when taking and returning > from signal handlers. My supplied test case shows that siga

Re: [Qemu-devel] [PATCH] linux-user: Enable sigaltstack syscall for sh4

2015-11-19 Thread Peter Maydell
On 18 November 2015 at 22:15, John Paul Adrian Glaubitz wrote: > --- > linux-user/syscall.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 6c64ba6..4d864b2 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscal

[Qemu-devel] [PATCH] linux-user: Enable sigaltstack syscall for sh4

2015-11-18 Thread John Paul Adrian Glaubitz
Hello! I'm the current maintainer for the Debian sh4 port. I maintain several buildds as well as port packages for the sh4 architecture. Recently I discovered qemu for building packages in an emulated chroot environment with qemu-sh4-static. While setting up python, qemu issued an error message a

[Qemu-devel] [PATCH] linux-user: Enable sigaltstack syscall for sh4

2015-11-18 Thread John Paul Adrian Glaubitz
--- linux-user/syscall.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 6c64ba6..4d864b2 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8294,7 +8294,8 @@ abi_long do_syscall(void *cpu_env, int num, abi_long