Re: [Qemu-devel] [PATCH] libvhost-user: fix SLAVE_SEND_FD handling

2019-09-03 Thread no-reply
] libvhost-user: fix SLAVE_SEND_FD handling === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT

[Qemu-devel] [PATCH] libvhost-user: fix SLAVE_SEND_FD handling

2019-09-03 Thread Johannes Berg
From: Johannes Berg It doesn't look like this could possibly work properly since VHOST_USER_PROTOCOL_F_SLAVE_SEND_FD is defined to 10, but the dev->protocol_features has a bitmap. I suppose the peer this was tested with also supported VHOST_USER_PROTOCOL_F_LOG_SHMFD, in which case the test would