Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-19 Thread Paolo Bonzini
On 17/01/2017 20:00, Michael S. Tsirkin wrote: >>> vhost user is not supposed to use maskfd at all. >>> >>> We have this code: >>>if (net->nc->info->type == NET_CLIENT_DRIVER_VHOST_USER) { >>>dev->use_guest_notifier_mask = false; >>>} >>> >>> isn't it effective? >> >>

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-17 Thread Michael S. Tsirkin
On Tue, Jan 17, 2017 at 06:53:17PM +, Felipe Franciosi wrote: > > > On 17 Jan 2017, at 10:41, Michael S. Tsirkin wrote: > > > > On Fri, Jan 13, 2017 at 10:29:46PM +, Felipe Franciosi wrote: > >> > >>> On 13 Jan 2017, at 10:18, Michael S. Tsirkin wrote: > >>> > >>> On Fri, Jan 13, 2017

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-17 Thread Felipe Franciosi
> On 17 Jan 2017, at 10:41, Michael S. Tsirkin wrote: > > On Fri, Jan 13, 2017 at 10:29:46PM +, Felipe Franciosi wrote: >> >>> On 13 Jan 2017, at 10:18, Michael S. Tsirkin wrote: >>> >>> On Fri, Jan 13, 2017 at 05:15:22PM +, Felipe Franciosi wrote: > On 13 Jan 2017, at 09:04

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-17 Thread Michael S. Tsirkin
On Mon, Jan 16, 2017 at 06:27:12PM +, Felipe Franciosi wrote: > Hi Michael, > > > On 16 Jan 2017, at 10:22, Michael S. Tsirkin wrote: > > > > On Thu, Jan 12, 2017 at 05:14:07PM -0800, Felipe Franciosi wrote: > >> Currently, VQs are started as soon as a SET_VRING_KICK is received. That > >> i

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-17 Thread Michael S. Tsirkin
On Fri, Jan 13, 2017 at 10:29:46PM +, Felipe Franciosi wrote: > > > On 13 Jan 2017, at 10:18, Michael S. Tsirkin wrote: > > > > On Fri, Jan 13, 2017 at 05:15:22PM +, Felipe Franciosi wrote: > >> > >>> On 13 Jan 2017, at 09:04, Michael S. Tsirkin wrote: > >>> > >>> On Fri, Jan 13, 2017

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-16 Thread Felipe Franciosi
Hi Michael, > On 16 Jan 2017, at 10:22, Michael S. Tsirkin wrote: > > On Thu, Jan 12, 2017 at 05:14:07PM -0800, Felipe Franciosi wrote: >> Currently, VQs are started as soon as a SET_VRING_KICK is received. That >> is too early in the VQ setup process, as the backend might not yet have >> a call

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-16 Thread Michael S. Tsirkin
On Thu, Jan 12, 2017 at 05:14:07PM -0800, Felipe Franciosi wrote: > Currently, VQs are started as soon as a SET_VRING_KICK is received. That > is too early in the VQ setup process, as the backend might not yet have > a callfd to notify in case it received a kick and fully processed the > request/co

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-13 Thread Felipe Franciosi
> On 13 Jan 2017, at 10:18, Michael S. Tsirkin wrote: > > On Fri, Jan 13, 2017 at 05:15:22PM +, Felipe Franciosi wrote: >> >>> On 13 Jan 2017, at 09:04, Michael S. Tsirkin wrote: >>> >>> On Fri, Jan 13, 2017 at 03:09:46PM +, Felipe Franciosi wrote: Hi Marc-Andre, > On 1

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-13 Thread Michael S. Tsirkin
On Fri, Jan 13, 2017 at 05:15:22PM +, Felipe Franciosi wrote: > > > On 13 Jan 2017, at 09:04, Michael S. Tsirkin wrote: > > > > On Fri, Jan 13, 2017 at 03:09:46PM +, Felipe Franciosi wrote: > >> Hi Marc-Andre, > >> > >>> On 13 Jan 2017, at 07:03, Marc-André Lureau wrote: > >>> > >>> H

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-13 Thread Felipe Franciosi
> On 13 Jan 2017, at 09:04, Michael S. Tsirkin wrote: > > On Fri, Jan 13, 2017 at 03:09:46PM +, Felipe Franciosi wrote: >> Hi Marc-Andre, >> >>> On 13 Jan 2017, at 07:03, Marc-André Lureau wrote: >>> >>> Hi >>> >>> - Original Message - Currently, VQs are started as soon as a

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-13 Thread Michael S. Tsirkin
On Fri, Jan 13, 2017 at 03:09:46PM +, Felipe Franciosi wrote: > Hi Marc-Andre, > > > On 13 Jan 2017, at 07:03, Marc-André Lureau wrote: > > > > Hi > > > > - Original Message - > >> Currently, VQs are started as soon as a SET_VRING_KICK is received. That > >> is too early in the VQ s

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-13 Thread Felipe Franciosi
Hi Marc-Andre, > On 13 Jan 2017, at 07:03, Marc-André Lureau wrote: > > Hi > > - Original Message - >> Currently, VQs are started as soon as a SET_VRING_KICK is received. That >> is too early in the VQ setup process, as the backend might not yet have > > I think we may want to reconsid

Re: [Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-13 Thread Marc-André Lureau
Hi - Original Message - > Currently, VQs are started as soon as a SET_VRING_KICK is received. That > is too early in the VQ setup process, as the backend might not yet have I think we may want to reconsider queue_set_started(), move it elsewhere, since kick/call fds aren't mandatory to p

[Qemu-devel] [PATCH] libvhost-user: Start VQs on SET_VRING_CALL

2017-01-12 Thread Felipe Franciosi
Currently, VQs are started as soon as a SET_VRING_KICK is received. That is too early in the VQ setup process, as the backend might not yet have a callfd to notify in case it received a kick and fully processed the request/command. This patch only starts a VQ when a SET_VRING_CALL is received. Sig