Re: [Qemu-devel] [PATCH] libvhost-user: Send messages with no data

2018-05-04 Thread Eric Blake
On 05/04/2018 04:53 AM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" The response to a VHOST_USER_POSTCOPY_ADVISE contains a fd but doesn't s/a fd/an fd/ ? Depends on whether you pronounce it "eff-dee" or "file-descriptor". actually contain any data. FIx vu_message

Re: [Qemu-devel] [PATCH] libvhost-user: Send messages with no data

2018-05-04 Thread Marc-André Lureau
On Fri, May 4, 2018 at 11:53 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The response to a VHOST_USER_POSTCOPY_ADVISE contains a fd but doesn't > actually contain any data. FIx vu_message_write so that it doesn't > do a 0-byte write() call, since this was ending

[Qemu-devel] [PATCH] libvhost-user: Send messages with no data

2018-05-04 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The response to a VHOST_USER_POSTCOPY_ADVISE contains a fd but doesn't actually contain any data. FIx vu_message_write so that it doesn't do a 0-byte write() call, since this was ending up with rc=0 that was confusing the error handling code. Signed-off-by: Dr. D