Re: [Qemu-devel] [PATCH] libcacard: Fix wrong assertion (reported by cppcheck)

2011-10-19 Thread Alon Levy
On Wed, Oct 19, 2011 at 09:03:22PM +0200, Stefan Weil wrote: > assert("...") will never do anything. This assertion handles a case > which should never occur, so it must be assert(!"..."). > Thanks, I'll pick it up for a pull request. > Cc: Alon Levy > Signed-off-by: Stefan Weil > --- > libca

[Qemu-devel] [PATCH] libcacard: Fix wrong assertion (reported by cppcheck)

2011-10-19 Thread Stefan Weil
assert("...") will never do anything. This assertion handles a case which should never occur, so it must be assert(!"..."). Cc: Alon Levy Signed-off-by: Stefan Weil --- libcacard/card_7816.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libcacard/card_7816.c b/libcac