Le 18/02/2014 17:16, Paolo Bonzini a écrit :
> This patch is not correct, because it introduces another one: if dirty
> logging was enabled on the memory region (kvm_dirty_pages_log_change),
> it will be disabled after migration.
Yes you're right that was my initial goal, I didn't distinguish the
Il 18/02/2014 13:33, Vincent KHERBACHE ha scritto:
diff --git a/kvm-all.c b/kvm-all.c
index 2ca9143..f104f87 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -355,7 +355,7 @@ static int kvm_set_migration_log(int enable)
{
KVMState *s = kvm_state;
KVMSlot *mem;
-int i, err;
+int i, err
Le 18/02/2014 14:23, Eric Blake a écrit :
>> -return err;
>> -}
>> +err = kvm_slot_dirty_pages_log_change(mem, (bool)enable);
>
> Is this a v2 post? Any reason you reposted without addressing my
> earlier review?
> https://lists.gnu.org/archive/html/qemu-devel/2014-02/
On 02/18/2014 05:33 AM, Vincent KHERBACHE wrote:
> The test (!!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES) == enable) is wrong
> because
> the condition is valid when enable = 0 and current dirty log memory flag is
> set.
> As a consequence kvm_log_global_stop() does not stop the KVM dirty log
> trac
The test (!!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES) == enable) is wrong because
the condition is valid when enable = 0 and current dirty log memory flag is set.
As a consequence kvm_log_global_stop() does not stop the KVM dirty log
tracking: kvm_set_migration_log(0) didn't do its job.
So instead I
