Re: [Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-04-01 Thread Michael S. Tsirkin
On Sat, Mar 31, 2012 at 12:15:34AM +0200, Jan Kiszka wrote: > On 2012-03-30 23:09, Alex Williamson wrote: > > On Fri, 2012-03-30 at 22:35 +0200, Jan Kiszka wrote: > >> On 2012-03-30 22:31, Jason Baron wrote: > >>> On Fri, Mar 30, 2012 at 10:18:31PM +0200, Jan Kiszka wrote: > >>> The root cause

Re: [Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-03-31 Thread Jan Kiszka
On 2012-03-30 21:18, Jason Baron wrote: > diff --git a/hw/device-assignment.c b/hw/device-assignment.c > index 89823f1..31aed17 100644 > --- a/hw/device-assignment.c > +++ b/hw/device-assignment.c > @@ -1609,10 +1609,32 @@ static void reset_assigned_device(DeviceState *dev) > { > PCIDevice *p

Re: [Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-03-30 Thread Jan Kiszka
On 2012-03-30 23:09, Alex Williamson wrote: > On Fri, 2012-03-30 at 22:35 +0200, Jan Kiszka wrote: >> On 2012-03-30 22:31, Jason Baron wrote: >>> On Fri, Mar 30, 2012 at 10:18:31PM +0200, Jan Kiszka wrote: >>> The root cause of the problem is that the 'reset_assigned_device()' code >>> firs

Re: [Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-03-30 Thread Alex Williamson
On Fri, 2012-03-30 at 22:35 +0200, Jan Kiszka wrote: > On 2012-03-30 22:31, Jason Baron wrote: > > On Fri, Mar 30, 2012 at 10:18:31PM +0200, Jan Kiszka wrote: > > The root cause of the problem is that the 'reset_assigned_device()' code > > first writes a 0 to the command register. Then, whe

Re: [Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-03-30 Thread Jan Kiszka
On 2012-03-30 22:31, Jason Baron wrote: > On Fri, Mar 30, 2012 at 10:18:31PM +0200, Jan Kiszka wrote: > The root cause of the problem is that the 'reset_assigned_device()' code > first writes a 0 to the command register. Then, when qemu subsequently > does > a kvm_deassign_irq() (c

Re: [Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-03-30 Thread Jason Baron
On Fri, Mar 30, 2012 at 10:18:31PM +0200, Jan Kiszka wrote: > >>> The root cause of the problem is that the 'reset_assigned_device()' code > >>> first writes a 0 to the command register. Then, when qemu subsequently > >>> does > >>> a kvm_deassign_irq() (called by assign_irq(), in the system_reset

Re: [Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-03-30 Thread Jan Kiszka
On 2012-03-30 22:13, Jason Baron wrote: > On Fri, Mar 30, 2012 at 09:29:23PM +0200, Jan Kiszka wrote: >> On 2012-03-30 21:18, Jason Baron wrote: >>> We've hit a kernel host panic, when issuing a 'system_reset' with a 82576 >>> nic >>> assigned and a Windows guest. Host system is a PowerEdge R815.

Re: [Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-03-30 Thread Jason Baron
On Fri, Mar 30, 2012 at 09:29:23PM +0200, Jan Kiszka wrote: > On 2012-03-30 21:18, Jason Baron wrote: > > We've hit a kernel host panic, when issuing a 'system_reset' with a 82576 > > nic > > assigned and a Windows guest. Host system is a PowerEdge R815. > > > > [Hardware Error]: Hardware error f

Re: [Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-03-30 Thread Jan Kiszka
On 2012-03-30 21:18, Jason Baron wrote: > We've hit a kernel host panic, when issuing a 'system_reset' with a 82576 nic > assigned and a Windows guest. Host system is a PowerEdge R815. > > [Hardware Error]: Hardware error from APEI Generic Hardware Error Source: > 32993 > [Hardware Error]: APEI g

[Qemu-devel] [PATCH] kvm: deassign irqs in reset path

2012-03-30 Thread Jason Baron
We've hit a kernel host panic, when issuing a 'system_reset' with a 82576 nic assigned and a Windows guest. Host system is a PowerEdge R815. [Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 32993 [Hardware Error]: APEI generic hardware error status [Hardware Error]: severi