Re: [Qemu-devel] [PATCH] kvm/apic: fix 2.2->2.1 migration

2015-01-20 Thread Markus Armbruster
Paolo Bonzini writes: > The wait_for_sipi field is set back to 1 after an INIT, so it was not > effective to reset it in kvm_apic_realize. Introduce a reset callback > and reset wait_for_sipi there. > > Reported-by: Igor Mammedov > Signed-off-by: Paolo Bonzini > --- > hw/i386/kvm/apic.c

Re: [Qemu-devel] [PATCH] kvm/apic: fix 2.2->2.1 migration

2014-12-12 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 12/12/2014 18:30, Dr. David Alan Gilbert wrote: > > OK, let me just check that I get this > > > > It gets reset to 0 already in kvm_apic_realize > > (before this patch -- after this patch it's only done in reset) > > > then we do the co

Re: [Qemu-devel] [PATCH] kvm/apic: fix 2.2->2.1 migration

2014-12-12 Thread Paolo Bonzini
On 12/12/2014 18:30, Dr. David Alan Gilbert wrote: > OK, let me just check that I get this > > It gets reset to 0 already in kvm_apic_realize (before this patch -- after this patch it's only done in reset) > then we do the common init Then as part of starting up auxiliary processors we se

Re: [Qemu-devel] [PATCH] kvm/apic: fix 2.2->2.1 migration

2014-12-12 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > The wait_for_sipi field is set back to 1 after an INIT, so it was not > effective to reset it in kvm_apic_realize. Introduce a reset callback > and reset wait_for_sipi there. > Reported-by: Igor Mammedov > Signed-off-by: Paolo Bonzini OK, let me

[Qemu-devel] [PATCH] kvm/apic: fix 2.2->2.1 migration

2014-12-10 Thread Paolo Bonzini
The wait_for_sipi field is set back to 1 after an INIT, so it was not effective to reset it in kvm_apic_realize. Introduce a reset callback and reset wait_for_sipi there. Reported-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- hw/i386/kvm/apic.c | 10 +++--- hw/intc/apic_c