Re: [Qemu-devel] [PATCH] ivshmem: fix potential OOB r/w access (#2)

2014-04-24 Thread Stefan Hajnoczi
On Wed, Apr 23, 2014 at 03:31:36PM +0200, Sebastian Krahmer wrote: Please put the patch revision number in the tags section of the commit message. This way git-am(1) automatically strips it when applying the patch. So: [PATCH] ivshmem: fix potential OOB r/w access (#2) should be: [PATCH v2] ivsh

[Qemu-devel] [PATCH] ivshmem: fix potential OOB r/w access (#2)

2014-04-23 Thread Sebastian Krahmer
Fix OOB access via malformed incoming_posn parameters and check that requested memory is actually alloced. tmp_fd does not leak on error; see following dup() call. According to docu g_realloc() may return NULL so we need to check that. Passes checkpatch.pl, after also fixing wrong ivshmem.c style