Re: [Qemu-devel] [PATCH] iscsi: Fix check for username

2015-03-09 Thread Paolo Bonzini
On 07/03/2015 10:14, Stefan Weil wrote: > The variable user in struct iscsi_url is a character array, not a pointer. > Therefore its address will never be NULL. > > clang reports this error: > > block/iscsi.c:1329:20: warning: > comparison of array 'iscsi_url->user' not equal to a null pointer

Re: [Qemu-devel] [PATCH] iscsi: Fix check for username

2015-03-07 Thread Peter Lieven
Am 07.03.2015 um 10:14 schrieb Stefan Weil: > The variable user in struct iscsi_url is a character array, not a pointer. > Therefore its address will never be NULL. > > clang reports this error: > > block/iscsi.c:1329:20: warning: > comparison of array 'iscsi_url->user' not equal to a null pointer

[Qemu-devel] [PATCH] iscsi: Fix check for username

2015-03-07 Thread Stefan Weil
The variable user in struct iscsi_url is a character array, not a pointer. Therefore its address will never be NULL. clang reports this error: block/iscsi.c:1329:20: warning: comparison of array 'iscsi_url->user' not equal to a null pointer is always true [-Wtautological-pointer-compare] Signe